From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77AE3C4332F for ; Sat, 1 Oct 2022 17:48:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229594AbiJARst (ORCPT ); Sat, 1 Oct 2022 13:48:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiJARsq (ORCPT ); Sat, 1 Oct 2022 13:48:46 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2E9C31DC7 for ; Sat, 1 Oct 2022 10:48:45 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id c30so9702292edn.2 for ; Sat, 01 Oct 2022 10:48:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=c7ClxOVX9/fTWh7RF9ZwpQ6vCvgaYcvgX8ui5h36zLw=; b=mk74V/+RqSnFY+c8okVl5tWdA9y2JDjEu+ZChC4UJ8UPHDQWf45g+AjBU59kzZEszF 8dQwl1pAvBY8rm+9GKnL5hP4KuF8Ffn0pyr/Sc7IDwnbWtY/wAdMI/MpVgrOU+FetnIz WmXLDxsCyhkqcyfmYZmOtiRHggmsRK18Cv3J3ZMCuEcvmpHQmp8sr5EVBi8x0XOq2S/p hDccOEEbesbAbwazZaK7z21XS5+H2JmV6h8/qBdY6sLAV9rLL1hgKNf76kZ2iGkgunyd p2QgSLOqew5T5xgRBs+r54wDDMFI6dhWkxE/KeCr2NHYMVxlSMUk71X48HpiK8sihnDF Xsgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=c7ClxOVX9/fTWh7RF9ZwpQ6vCvgaYcvgX8ui5h36zLw=; b=JkAJMMJ1lKQxYuSEJNWrVj5vCIjwbKNW685AXS4xH/EHct4e2wU4TlisRnRCvPjgVx GPeiupMPpcML5CvF1sTlTSbRCgvPdEiZWVXJTzdGUnu1h27nFVtx7E0p6Z6AbmjunoFF oEUHLe2lu74kx3QyJa3lMo264lQMluHUgA29Kusfa4wHvL5dmidYZ6Q2BNtVpXJ+GcXq IjcSt25wxG+60z7USptnAxnfeXj+jx6BOqhwt8mEChCeV8aL/JY9H1Wg0e15iJ9lNx2I ba8XCKPIx8aN0r6KVuLgnGE9EJLKgiwc7mviNpo1X/LJ1BhaaqQ09FRBmD8gAzup8CJS aJAw== X-Gm-Message-State: ACrzQf3yTRRrl5DeppxM8KyHrT4Xe7Ghx7WLfUGSj38xPjRdT4gJoD0e kwhu2iqIaSy/rTkF4nwrUrxW3nKgMdQ9Es3nkRdBsQ== X-Google-Smtp-Source: AMsMyM7HypsGCtGwX3FxtKtIGc7+9dBKBWCGfn6+4lUOJYG/BvyZ0yhYOcX4mu3QAc5qVPq0R+H765Ju0VHIOz8nwt0= X-Received: by 2002:aa7:d39a:0:b0:458:a612:f805 with SMTP id x26-20020aa7d39a000000b00458a612f805mr4014103edq.49.1664646524412; Sat, 01 Oct 2022 10:48:44 -0700 (PDT) MIME-Version: 1.0 References: <20221001002638.2881842-1-dlatypov@google.com> <20221001002638.2881842-4-dlatypov@google.com> In-Reply-To: From: Daniel Latypov Date: Sat, 1 Oct 2022 10:48:33 -0700 Message-ID: Subject: Re: [PATCH 3/4] kunit: eliminate KUNIT_INIT_*_ASSERT_STRUCT macros To: Miguel Ojeda Cc: brendanhiggins@google.com, davidgow@google.com, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 1, 2022 at 3:12 AM Miguel Ojeda wrote: > > On Sat, Oct 1, 2022 at 2:26 AM Daniel Latypov wrote: > > > > But we can work around this with the following generic macro > > #define KUNIT_INIT_ASSERT(initializers...) { initializers } > > Is it intended to be internal, right? Should be prefixed by `_` then? Yeah, 100% internal. We don't have such a convention in KUnit yet, see the discussion in https://lore.kernel.org/linux-kselftest/CABVgOSmcheQvBRKqc-0ftmbthx=EReoQ-910QV0QMNuxLWjTUQ@mail.gmail.com/T/#u I'd be personally fine with _s, but this patch just tried to keep things consistent with what was there before. Daniel