From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 963C9C433EF for ; Wed, 18 May 2022 15:31:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239373AbiERPbr (ORCPT ); Wed, 18 May 2022 11:31:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239360AbiERPbl (ORCPT ); Wed, 18 May 2022 11:31:41 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE5953A73E for ; Wed, 18 May 2022 08:31:39 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id tk15so4548664ejc.6 for ; Wed, 18 May 2022 08:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BsKITgJe0n74ro4jmQWlnQSOXtIrCCeeoRj5fvJvlc0=; b=QbX9x8QYId9IYqLSJLz7B0lNYR5Ysq9SBtezIFgF9MxRuFFhgUQb08yofIQ91NjF6T j8BNWfBXTMUcqev9dUOJvjngjgkinx9SiYS0zg/d9CVznombWSAUvvOCZa/PuaVB3gwN 1uqYIsQhnkwLB7akZjsrIp2VfWC1BcVGVCaD0AAVV3T+AUJkM9grUxrjgGOUlcbpCJ7Q IeWC5F8GO0y6JSidBbBMapnVKYFFwBBW9XUYgsKDbR2gGqbLYPKMNNiaZDRzEa24wDKr j8pNn6PckGBWkyQaarY2OOp8IP9hmqxUkTcK3KmWub42D4ReKkPddXGxFnJ7tv5ZqaV9 jJsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BsKITgJe0n74ro4jmQWlnQSOXtIrCCeeoRj5fvJvlc0=; b=WozQ/mV4x4qJc8tKjG6i78kpE8WgtDljdmfuAHafLW4lwhaYVjIt3zNzubVXn07fbq QjydCXSGDJeoNrui1weGC2OW+iacDp+I8y6/2vABTRl6VGj9oywF9cVYxyyNlPZcKuT1 34pLd8BCZ7Q2K9aBOKjC1C3NGjWN8mKsIRBx1gHxAE2mCj59gnAo8nGl29HvTG16z23/ fGTXj/6TwGGfNINRP2Odaflz2WHkai3RQhrqfEJ2QQQuSKOSElkyjMSbVUBQLA3mv8gh CpappneBNngkd5BT6mzhYdTLwqTbC7dg0MHT3oHns6eDz931P4+UP/mJ0HiwPQyU/jS1 XpoA== X-Gm-Message-State: AOAM5324IJuS58cKWj9n4fOmXrFG5+uFsZ83Z5amLp101dbSOYibzG64 XVkuseZxiAOLPe5ee+cxrvoUW4TFSw7l4o1abOOKPw== X-Google-Smtp-Source: ABdhPJypdAwNsHGSQOCFoNHLEpvFi/jgA+FFF6DbVWnbkiIb+knGUAlhkoYYf6uCpI4qtHTl6NSZOVNx73Y9TpbSvCE= X-Received: by 2002:a17:907:2cc7:b0:6fa:7356:f411 with SMTP id hg7-20020a1709072cc700b006fa7356f411mr118908ejc.369.1652887898099; Wed, 18 May 2022 08:31:38 -0700 (PDT) MIME-Version: 1.0 References: <20220518073232.526443-1-davidgow@google.com> In-Reply-To: <20220518073232.526443-1-davidgow@google.com> From: Daniel Latypov Date: Wed, 18 May 2022 08:31:27 -0700 Message-ID: Subject: Re: [PATCH 1/2] kunit: tool: Add x86_64-smp architecture for SMP testing To: David Gow Cc: Brendan Higgins , Marco Elver , Shuah Khan , Dmitry Vyukov , kunit-dev@googlegroups.com, kasan-dev@googlegroups.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 18, 2022 at 12:32 AM 'David Gow' via KUnit Development wrote: > > Add a new QEMU config for kunit_tool, x86_64-smp, which provides an > 8-cpu SMP setup. No other kunit_tool configurations provide an SMP > setup, so this is the best bet for testing things like KCSAN, which > require a multicore/multi-cpu system. > > The choice of 8 CPUs is pretty arbitrary: it's enough to get tests like > KCSAN to run with a nontrivial number of worker threads, while still > working relatively quickly on older machines. > Since it's arbitrary, I somewhat prefer the idea of leaving up entirely to the caller i.e. $ kunit.py run --kconfig_add=CONFIG_SMP=y --qemu_args '-smp 8' We could add CONFIG_SMP=y to the default qemu_configs/*.py and do $ kunit.py run --qemu_args '-smp 8' but I'd prefer the first, even if it is more verbose. Marco, does this seem reasonable from your perspective? I think that a new --qemu_args would be generically useful for adhoc use and light enough that people won't need to add qemu_configs much. E.g. I can see people wanting multiple NUMA nodes, a specific -cpu, and so on.