From: Chanwoo Choi <cwchoi00@gmail.com>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, dl-linux-imx <linux-imx@nxp.com>,
Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
yuq825@gmail.com, David Airlie <airlied@linux.ie>,
daniel@ffwll.ch, robdclark@gmail.com, sean@poorly.run,
Rob Herring <robh@kernel.org>,
tomeu.vizoso@collabora.com, steven.price@arm.com,
alyssa.rosenzweig@collabora.com, stanimir.varbanov@linaro.org,
agross@kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>,
mchehab@kernel.org, Lukasz Luba <lukasz.luba@arm.com>,
adrian.hunter@intel.com, Ulf Hansson <ulf.hansson@linaro.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>, Mark Brown <broonie@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
jirislaby@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
jcrouse@codeaurora.org, hoegsberg@google.com, eric@anholt.net,
tzimmermann@suse.de, marijn.suijten@somainline.org,
gustavoars@kernel.org, emil.velikov@collabora.com,
jonathan@marek.ca, akhilpo@codeaurora.org,
smasetty@codeaurora.org, airlied@redhat.com,
masneyb@onstation.org, kalyan_t@codeaurora.org,
tanmay@codeaurora.org, ddavenport@chromium.org,
jsanka@codeaurora.org, rnayak@codeaurora.org,
tongtiangen@huawei.com, miaoqinglang@huawei.com,
khsieh@codeaurora.org, abhinavk@codeaurora.org,
chandanu@codeaurora.org, Guenter Roeck <groeck@chromium.org>,
varar@codeaurora.org, Matthias Kaehlcke <mka@chromium.org>,
harigovi@codeaurora.org, rikard.falkeborn@gmail.com,
natechancellor@gmail.com,
Georgi Djakov <georgi.djakov@linaro.org>,
akashast@codeaurora.org, parashar@codeaurora.org,
Doug Anderson <dianders@chromium.org>,
Linux PM list <linux-pm@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-tegra@vger.kernel.org,
dri-devel <dri-devel@lists.freedesktop.org>,
lima@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
freedreno@lists.freedesktop.org, linux-media@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 28/31] PM / devfreq: imx8m-ddrc: convert to use devm_pm_opp_* API
Date: Tue, 5 Jan 2021 13:13:35 +0900 [thread overview]
Message-ID: <CAGTfZH37=e4RgdR4xg-3s9-pRjqunHi2jfPQqQgVWkxW94GwOA@mail.gmail.com> (raw)
In-Reply-To: <20210103035540.23886-1-tiny.windzz@gmail.com>
On Sun, Jan 3, 2021 at 12:58 PM Yangtao Li <tiny.windzz@gmail.com> wrote:
>
> Use devm_pm_opp_* API to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/devfreq/imx8m-ddrc.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/devfreq/imx8m-ddrc.c b/drivers/devfreq/imx8m-ddrc.c
> index bc82d3653bff..9383d6e5538b 100644
> --- a/drivers/devfreq/imx8m-ddrc.c
> +++ b/drivers/devfreq/imx8m-ddrc.c
> @@ -370,11 +370,6 @@ static int imx8m_ddrc_check_opps(struct device *dev)
> return 0;
> }
>
> -static void imx8m_ddrc_exit(struct device *dev)
> -{
> - dev_pm_opp_of_remove_table(dev);
> -}
> -
> static int imx8m_ddrc_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> @@ -419,7 +414,7 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
> return ret;
> }
>
> - ret = dev_pm_opp_of_add_table(dev);
> + ret = devm_pm_opp_of_add_table(dev);
> if (ret < 0) {
> dev_err(dev, "failed to get OPP table\n");
> return ret;
> @@ -427,12 +422,11 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
>
> ret = imx8m_ddrc_check_opps(dev);
> if (ret < 0)
> - goto err;
> + return ret;
>
> priv->profile.polling_ms = 1000;
> priv->profile.target = imx8m_ddrc_target;
> priv->profile.get_dev_status = imx8m_ddrc_get_dev_status;
> - priv->profile.exit = imx8m_ddrc_exit;
> priv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq;
> priv->profile.initial_freq = clk_get_rate(priv->dram_core);
>
> @@ -441,13 +435,8 @@ static int imx8m_ddrc_probe(struct platform_device *pdev)
> if (IS_ERR(priv->devfreq)) {
> ret = PTR_ERR(priv->devfreq);
> dev_err(dev, "failed to add devfreq device: %d\n", ret);
> - goto err;
> }
>
> - return 0;
> -
> -err:
> - dev_pm_opp_of_remove_table(dev);
> return ret;
devm_devfreq_add_device() doesn't return any integer value.
Even if devm_devfreq_add_device() returns the right devfreq instance,
the 'ret' value is not the return value of devm_devfreq_add_device().
On this patch, 'ret' value of 'return ret' is from imx8m_ddrc_check_opps().
Surely, it is well working with this modification. But, it is not code
for exception handling.
So, we need to remain the following codes:
return 0;
err:
return ret;
> }
>
> --
> 2.25.1
>
--
Best Regards,
Chanwoo Choi
next prev parent reply other threads:[~2021-01-05 4:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 3:55 [PATCH 28/31] PM / devfreq: imx8m-ddrc: convert to use devm_pm_opp_* API Yangtao Li
2021-01-05 4:13 ` Chanwoo Choi [this message]
2021-01-05 19:59 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGTfZH37=e4RgdR4xg-3s9-pRjqunHi2jfPQqQgVWkxW94GwOA@mail.gmail.com' \
--to=cwchoi00@gmail.com \
--cc=abhinavk@codeaurora.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=akashast@codeaurora.org \
--cc=akhilpo@codeaurora.org \
--cc=alyssa.rosenzweig@collabora.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=chandanu@codeaurora.org \
--cc=cw00.choi@samsung.com \
--cc=daniel@ffwll.ch \
--cc=ddavenport@chromium.org \
--cc=dianders@chromium.org \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=eric@anholt.net \
--cc=festevam@gmail.com \
--cc=freedreno@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=harigovi@codeaurora.org \
--cc=hoegsberg@google.com \
--cc=jcrouse@codeaurora.org \
--cc=jirislaby@kernel.org \
--cc=jonathan@marek.ca \
--cc=jonathanh@nvidia.com \
--cc=jsanka@codeaurora.org \
--cc=kalyan_t@codeaurora.org \
--cc=kernel@pengutronix.de \
--cc=khsieh@codeaurora.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lima@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=marijn.suijten@somainline.org \
--cc=masneyb@onstation.org \
--cc=mchehab@kernel.org \
--cc=miaoqinglang@huawei.com \
--cc=mka@chromium.org \
--cc=myungjoo.ham@samsung.com \
--cc=natechancellor@gmail.com \
--cc=nm@ti.com \
--cc=parashar@codeaurora.org \
--cc=rikard.falkeborn@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=shawnguo@kernel.org \
--cc=smasetty@codeaurora.org \
--cc=stanimir.varbanov@linaro.org \
--cc=steven.price@arm.com \
--cc=tanmay@codeaurora.org \
--cc=thierry.reding@gmail.com \
--cc=tiny.windzz@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tongtiangen@huawei.com \
--cc=tzimmermann@suse.de \
--cc=ulf.hansson@linaro.org \
--cc=varar@codeaurora.org \
--cc=vireshk@kernel.org \
--cc=yuq825@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).