From: "Lukáš Lalinský" <lukas@oxygene.sk>
To: Oliver Neukum <oneukum@suse.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: Add quirk for WORLDE easykey.25 MIDI keyboard
Date: Tue, 24 Jan 2017 09:31:09 +0100 [thread overview]
Message-ID: <CAGUtLj9ne2_7Cr6zA4zvBHcUKLUSGjZ0_TDoz3pTbp6htK_ruw@mail.gmail.com> (raw)
In-Reply-To: <CAGUtLj8cWp-WPx8up90CHYDJ-Xvgc6Wmb3FsQYnn_ThY4htOPw@mail.gmail.com>
On Tue, Jan 24, 2017 at 8:37 AM, Lukáš Lalinský <lukas@oxygene.sk> wrote:
> On Tue, Jan 24, 2017 at 8:32 AM, Oliver Neukum <oneukum@suse.com> wrote:
>> Am Montag, den 23.01.2017, 19:36 +0100 schrieb Lukáš Lalinský:
>>> I have uploaded both captures here -
>>> https://gist.github.com/lalinsky/83148a827d5cd43e79e377d8e1b5ed0d
>>
>> Indeed it is does not set a configuration. Either the capture
>> is incomplete or device and host violate the standard. A device
>> may be left unconfigured.
>
> Is this may or may not? I'm not familiar with USB, so I assumed if
> there is only one configuration and there is always one active, it
> does not need to be set explicitly because the correct one is already
> active.
>
>> We need to read the descriptors even if we
>> see only one configuration to get the power budgeting right.
>
> Aren't those in the CONFIGURATION descriptors? Reading the STRING
> descriptor is probably only useful if you need to print the
> configuration details somewhere.
I re-ran the capture on a Windows 7 host. The previous capture was
missing data, probably due to interactions of the Linux host and
Windows VM.
https://gist.github.com/lalinsky/2ec7d74b049b448b1f7032d8861ca4a2
It does set the configuration, but does not request the string descriptor.
Lukas
prev parent reply other threads:[~2017-01-24 8:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 18:46 [PATCH] USB: Add quirk for WORLDE easykey.25 MIDI keyboard Lukáš Lalinský
2017-01-21 9:08 ` Greg Kroah-Hartman
2017-01-23 18:36 ` Lukáš Lalinský
2017-01-24 7:32 ` Oliver Neukum
2017-01-24 7:37 ` Lukáš Lalinský
2017-01-24 8:30 ` Oliver Neukum
2017-01-24 8:31 ` Lukáš Lalinský [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGUtLj9ne2_7Cr6zA4zvBHcUKLUSGjZ0_TDoz3pTbp6htK_ruw@mail.gmail.com \
--to=lukas@oxygene.sk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).