Re: [PATCH 7/8] lib: overflow: update reference to kunit-tool

From: Tales <tales.aparecida@gmail.com>
To: Daniel Latypov <dlatypov@google.com>
Cc: "Sadiya Kazi" <sadiyakazi@google.com>,
	"Kees Cook" <keescook@chromium.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"KUnit Development" <kunit-dev@googlegroups.com>,
	linux-doc@vger.kernel.org,
	"open list:KERNEL SELFTEST FRAMEWORK"
	<linux-kselftest@vger.kernel.org>,
	"David Gow" <davidgow@google.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Brendan Higgins" <brendan.higgins@linux.dev>,
	"Trevor Woerner" <twoerner@gmail.com>,
	siqueirajordao@riseup.net, "Melissa Wen" <mwen@igalia.com>,
	"André Almeida" <andrealmeid@riseup.net>,
	"Maíra Canal" <mairacanal@riseup.net>,
	"Isabella Basso" <isabbasso@riseup.net>,
	"Magali Lemes" <magalilemes00@gmail.com>,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH 7/8] lib: overflow: update reference to kunit-tool
Date: Mon, 22 Aug 2022 20:12:09 -0300	[thread overview]
Message-ID: <CAGVoLp5zv5CR_Jo-dboaYF+7_8whV=rvfJHRGeVhNRTn6LzMoA@mail.gmail.com> (raw)
In-Reply-To: <CAGS_qxrGVHWiEQz5b+zWz0JYmUwxnsVaoa_8SYOxb7nsRZ=iSw@mail.gmail.com>

Em seg., 22 de ago. de 2022 às 19:52, Daniel Latypov
<dlatypov@google.com> escreveu:
>
> On Mon, Aug 22, 2022 at 3:35 PM Tales <tales.aparecida@gmail.com> wrote:
> >
> > Hi Daniel,
> >
> > Em seg., 22 de ago. de 2022 às 17:09, Daniel Latypov
> > <dlatypov@google.com> escreveu:
> > >
> > > On Thu, Aug 18, 2022 at 10:33 PM Tales Aparecida
> > > <tales.aparecida@gmail.com> wrote:
> > > >
> > > > Replace URL with an updated path to the full Documentation page
> > > >
> > > > Signed-off-by: Tales Aparecida <tales.aparecida@gmail.com>
> > > > ---
> > > >  lib/overflow_kunit.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c
> > > > index 7e3e43679b73..78075106c0df 100644
> > > > --- a/lib/overflow_kunit.c
> > > > +++ b/lib/overflow_kunit.c
> > > > @@ -1,7 +1,7 @@
> > > >  // SPDX-License-Identifier: GPL-2.0 OR MIT
> > > >  /*
> > > >   * Test cases for arithmetic overflow checks. See:
> > > > - * https://www.kernel.org/doc/html/latest/dev-tools/kunit/kunit-tool.html#configuring-building-and-running-tests
> > > > + * "Running tests with kunit_tool" at Documentation/dev-tools/kunit/start.rst
> > >
> > > Oh, I thought I had sent a patch out for this.
> > > The rewritten version of the patch is
> > > https://www.kernel.org/doc/html/latest/dev-tools/kunit/run_wrapper.html
> > > That's what I was intending to rewrite this line to point to.
> > >
> > > But if people like a Documentation/ path to start.rst instead, that also works.
> > >
> > > Daniel
> >
> > You are absolutely right! You did send and I wasn't aware, sorry.
> > https://lore.kernel.org/all/20220603195626.121922-1-dlatypov@google.com/
> > I guess it stalled after that discussion about *where* it should be applied,
> > I got a green flag in IRC and didn't do my due diligence carefully,
> > just tried to find pending patches at linux-kselftest which wasn't
> > CC'd
>
> Oh right, it was that series where I didn't cc linux-kselftest.
> That was my bad, sorry.
>
> But I had forgotten to include a patch in that series to update this
> file still, afaict.
> I could revive that series and add on a version of this patch, if we want?
>
> Daniel

I can bring your patches in my V3, if you don't mind! :D