From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753571AbcFONLU (ORCPT ); Wed, 15 Jun 2016 09:11:20 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:32947 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752789AbcFONLO convert rfc822-to-8bit (ORCPT ); Wed, 15 Jun 2016 09:11:14 -0400 MIME-Version: 1.0 In-Reply-To: <20160613123514.GF27930@ulmo.ba.sec> References: <1465813529-30621-1-git-send-email-simhavcs@gmail.com> <1465813529-30621-2-git-send-email-simhavcs@gmail.com> <20160613123514.GF27930@ulmo.ba.sec> From: Vinay Simha Date: Wed, 15 Jun 2016 18:41:11 +0530 Message-ID: Subject: Re: [PATCH v4 2/2] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel To: Thierry Reding Cc: Archit Taneja , Sumit Semwal , John Stultz , Rob Clark , David Airlie , open list , "open list:DRM PANEL DRIVERS" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 13, 2016 at 6:05 PM, Thierry Reding wrote: > On Mon, Jun 13, 2016 at 03:55:28PM +0530, Vinay Simha BN wrote: >> Add support for the JDI lt070me05000 WUXGA DSI panel used in > > Can you please make the names consistent? Use the all-uppercase spelling > for the panel model. > >> Nexus 7 2013 devices. >> >> Programming sequence for the panel is was originally found in the >> android-msm-flo-3.4-lollipop-release branch from: >> https://android.googlesource.com/kernel/msm.git >> >> And video mode setting is from dsi-panel-jdi-dualmipi1-video.dtsi >> file in: >> git://codeaurora.org/kernel/msm-3.10.git LNX.LA.3.6_rb1.27 >> >> Cc: Archit Taneja >> [sumit.semwal: Ported to the drm/panel framework] >> Signed-off-by: Sumit Semwal >> [jstultz: Cherry-picked to mainline, folded down other fixes >> from Vinay and Archit] >> Signed-off-by: John Stultz >> [vinay simha bn: removed interface setting cmd mode, video >> mode panel setting selection] >> Cc: Rob Clark >> Signed-off-by: Vinay Simha BN >> -- >> v2: >> * incorporated code reviews from theiry, archit >> code style, alphabetical soring in Makefile, Kconfig, regulator_bulk, >> arrays of u8, generic helper function, documentation bindings, >> >> v3: >> * dcs backlight support added >> * tested this panel driver in nexus7 2013 device >> >> v4: >> * backlight interface added in the panel driver >> * incorporated width_mm and height_mm suggested by rob herring >> --- >> drivers/gpu/drm/panel/Kconfig | 11 + >> drivers/gpu/drm/panel/Makefile | 1 + >> drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 539 +++++++++++++++++++++++++ >> 3 files changed, 551 insertions(+) >> create mode 100644 drivers/gpu/drm/panel/panel-jdi-lt070me05000.c >> >> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig >> index 1500ab9..83e89e7 100644 >> --- a/drivers/gpu/drm/panel/Kconfig >> +++ b/drivers/gpu/drm/panel/Kconfig >> @@ -7,6 +7,17 @@ config DRM_PANEL >> menu "Display Panels" >> depends on DRM && DRM_PANEL >> >> +config DRM_PANEL_JDI_LT070ME05000 >> + tristate "JDI LT070ME05000 WUXGA DSI panel" >> + depends on OF >> + depends on DRM_MIPI_DSI >> + depends on BACKLIGHT_CLASS_DEVICE >> + help > > Please use consistent indentation here. Also, this is badly sorted. The > DRM_PANEL_SIMPLE is special in that it doesn't have a vendor prefix, all > others should be sorted after panel-simple and in alphabetical order by > vendor, then model. > >> + Say Y here if you want to enable support for JDI WUXGA DSI video >> + mode panel as found in Google Nexus 7 (2013) devices. >> + The panel has a 1200(RGB)×1920 (WUXGA) resolution and uses >> + 24 bit RGB per pixel. > > It's kind of redundant to say 1200(RGB) when you say that it's 24 bit > RGB afterwards. You also repeat WUXGA twice, so you can drop either of > the occurrences as well. > >> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile >> index f277eed..5d74ac2 100644 >> --- a/drivers/gpu/drm/panel/Makefile >> +++ b/drivers/gpu/drm/panel/Makefile >> @@ -1,3 +1,4 @@ >> +obj-$(CONFIG_DRM_PANEL_JDI_LT070ME05000) += panel-jdi-lt070me05000.o > > Please sort this the same way as the Kconfig entries. > >> obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o >> obj-$(CONFIG_DRM_PANEL_LG_LG4573) += panel-lg-lg4573.o >> obj-$(CONFIG_DRM_PANEL_PANASONIC_VVX10F034N00) += panel-panasonic-vvx10f034n00.o >> diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c >> new file mode 100644 >> index 0000000..8657e5f >> --- /dev/null >> +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c >> @@ -0,0 +1,539 @@ >> +/* >> + * Copyright (C) 2016 InforceComputing >> + * Author: Vinay Simha BN >> + * >> + * Copyright (C) 2016 Linaro Ltd >> + * Author: Sumit Semwal >> + * >> + * From internet archives, the panel for Nexus 7 2nd Gen, 2013 model is a >> + * JDI model LT070ME05000, and its data sheet is at: >> + * http://panelone.net/en/7-0-inch/JDI_LT070ME05000_7.0_inch-datasheet >> + * >> + * This program is free software; you can redistribute it and/or modify it >> + * under the terms of the GNU General Public License version 2 as published by >> + * the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, but WITHOUT >> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for >> + * more details. >> + * >> + * You should have received a copy of the GNU General Public License along with >> + * this program. If not, see . >> + */ >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +#include >> +#include >> +#include >> +#include >> + >> +#include