From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbcF1P7U (ORCPT ); Tue, 28 Jun 2016 11:59:20 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:35632 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752042AbcF1P7S (ORCPT ); Tue, 28 Jun 2016 11:59:18 -0400 MIME-Version: 1.0 In-Reply-To: <1466402029-23252-1-git-send-email-simhavcs@gmail.com> References: <1466402029-23252-1-git-send-email-simhavcs@gmail.com> From: Vinay Simha Date: Tue, 28 Jun 2016 21:29:04 +0530 Message-ID: Subject: Re: [PATCH v2 1/2] drm/dsi: Implement dcs set/get display brightness To: Vinay Simha BN Cc: John Stultz , Sumit Semwal , Archit Taneja , Rob Clark , Jani Nikula , Thierry Reding , David Airlie , "open list:DRM DRIVERS" , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi, Any further comments or reviews? On Mon, Jun 20, 2016 at 11:23 AM, Vinay Simha BN wrote: > Provide a small convenience wrapper that set/get the > display brightness value > > Cc: John Stultz > Cc: Sumit Semwal > Cc: Archit Taneja > Cc: Rob Clark > Cc: Jani Nikula > Cc: Thierry Reding > Signed-off-by: Vinay Simha BN > --- > v1: > *tested in nexus7 2nd gen. > > v2: > * implemented jani review comments > -functions name mapped accordingly > -bl value increased from 0xff to 0xffff > -backlight interface will be handled in panel driver, > so it is moved from the mipi_dsi helper function > --- > drivers/gpu/drm/drm_mipi_dsi.c | 49 ++++++++++++++++++++++++++++++++++++++++++ > include/drm/drm_mipi_dsi.h | 4 ++++ > 2 files changed, 53 insertions(+) > > diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c > index 49311fc..2c03784 100644 > --- a/drivers/gpu/drm/drm_mipi_dsi.c > +++ b/drivers/gpu/drm/drm_mipi_dsi.c > @@ -1041,6 +1041,55 @@ int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format) > } > EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format); > > +/** > + * mipi_dsi_dcs_get_display_brightness() - gets the current brightness value > + * of the display > + * @dsi: DSI peripheral device > + * @brightness: brightness value > + * > + * Return: 0 on success or a negative error code on failure. > + */ > +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi, > + u16 *brightness) > +{ > + ssize_t err; > + > + err = mipi_dsi_dcs_read(dsi, MIPI_DCS_GET_DISPLAY_BRIGHTNESS, > + brightness, sizeof(*brightness)); > + if (err < 0) { > + if (err == 0) > + err = -ENODATA; > + > + return err; > + } > + > + return 0; > +} > +EXPORT_SYMBOL(mipi_dsi_dcs_get_display_brightness); > + > +/** > + * mipi_dsi_dcs_set_display_brightness() - sets the brightness value of > + * the display > + * @dsi: DSI peripheral device > + * @brightness: brightness value > + * > + * Return: 0 on success or a negative error code on failure. > + */ > +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, > + u16 brightness) > +{ > + ssize_t err; > + u8 bl_value[2] = { brightness & 0xff, brightness >> 8 }; > + > + err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_DISPLAY_BRIGHTNESS, > + bl_value, sizeof(bl_value)); > + if (err < 0) > + return err; > + > + return 0; > +} > +EXPORT_SYMBOL(mipi_dsi_dcs_set_display_brightness); > + > static int mipi_dsi_drv_probe(struct device *dev) > { > struct mipi_dsi_driver *drv = to_mipi_dsi_driver(dev->driver); > diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h > index 72f5b15..4d77bb0 100644 > --- a/include/drm/drm_mipi_dsi.h > +++ b/include/drm/drm_mipi_dsi.h > @@ -270,6 +270,10 @@ int mipi_dsi_dcs_set_tear_off(struct mipi_dsi_device *dsi); > int mipi_dsi_dcs_set_tear_on(struct mipi_dsi_device *dsi, > enum mipi_dsi_dcs_tear_mode mode); > int mipi_dsi_dcs_set_pixel_format(struct mipi_dsi_device *dsi, u8 format); > +int mipi_dsi_dcs_get_display_brightness(struct mipi_dsi_device *dsi, > + u16 *brightness); > +int mipi_dsi_dcs_set_display_brightness(struct mipi_dsi_device *dsi, > + u16 brightness); > > /** > * struct mipi_dsi_driver - DSI driver > -- > 2.1.2 > -- Regards, Vinay Simha.B.N.