From: Kees Cook <keescook@chromium.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vinson Lee <vlee@freedesktop.org>
Subject: Re: [GIT PULL] usercopy fixes for v4.8-rc6-part2
Date: Wed, 7 Sep 2016 14:48:46 -0700 [thread overview]
Message-ID: <CAGXu5j+710yM8Ns+bWCae22LcSNiL=d5CqYX47vUBA93SUHaLA@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5j+iKpW90FMRYRD9Gru489jiKdvAr9wth1ygE9vxOg2PXA@mail.gmail.com>
On Wed, Sep 7, 2016 at 2:32 PM, Kees Cook <keescook@chromium.org> wrote:
> On Wed, Sep 7, 2016 at 12:15 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>> On Wed, Sep 7, 2016 at 11:36 AM, Kees Cook <keescook@chromium.org> wrote:
>>>
>>> - move page-spanning check behind a CONFIG since it's triggering false positives
>>
>> Hmm. I pulled this, but looking at it I realized that
>>
>> + depends on !COMPILE_TEST
>>
>> doesn't make any real sense to me.
>>
>> All it does is make sure that "make allmodconfig" doesn't actually
>> test that the PAGESPAN code compiles.
>>
>> It's not like that is a big cost for allmodconfig builds, but it does
>> mean that it gets less coverage.
>>
>> And it really makes no sense to me. We *don't* want to run with that
>> option enabled normally.
>>
>> I think what you actually meant was something like
>>
>> + depends on EXPERT
>>
>> which means that it does *not* get enabled in normal user builds.
>>
>> Hmm?
>
> I guess that's true -- I was trying to think of a way to make sure it
> didn't get tested by 0-day syscall fuzzer on a randconfig, since I
> didn't want the noise. But now that I double-check this, yeah, it
> looks like randconfig doesn't set COMPILE_TEST. Hmpf.
>
> I will send another patch to flip this to EXPERT, and if 0-day finds
> issues, I can add them to the __GPF_COMP hit-list. :P
Oh! Nevermind, I see you did that already. Thank you! :)
-Kees
--
Kees Cook
Nexus Security
prev parent reply other threads:[~2016-09-07 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 18:36 [GIT PULL] usercopy fixes for v4.8-rc6-part2 Kees Cook
2016-09-07 19:15 ` Linus Torvalds
2016-09-07 21:32 ` Kees Cook
2016-09-07 21:48 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5j+710yM8Ns+bWCae22LcSNiL=d5CqYX47vUBA93SUHaLA@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vlee@freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).