linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Laura Abbott <labbott@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	"x86@kernel.org" <x86@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/mm: Set __vmalloc_start_set in numa_32.c
Date: Mon, 8 May 2017 15:28:42 -0700	[thread overview]
Message-ID: <CAGXu5j+E9AGn8SosiBv921gt0Te-Xh4cTr4XYh0MD-jueDnorw@mail.gmail.com> (raw)
In-Reply-To: <1494278596-30373-1-git-send-email-labbott@redhat.com>

On Mon, May 8, 2017 at 2:23 PM, Laura Abbott <labbott@redhat.com> wrote:
> __vmalloc_start_set currently only gets set in initmem_init when
> !CONFIG_NEED_MULTIPLE_NODES. This currently breaks detection of vmalloc
> address with virt_addr_valid with CONFIG_NEED_MULTIPLE_NODES=y.
> Set __vmalloc_start_set appropriately for that case as well.
>
> Fixes: dc16ecf7fd1f ("x86-32: use specific __vmalloc_start_set flag in __virt_addr_valid")q

Nit: trailing "q" typo

> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Laura Abbott <labbott@redhat.com>

Reviewed-by: Kees Cook <keescook@chromium.org>

Thanks for tracking this down!

-Kees

> ---
>  arch/x86/mm/numa_32.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/x86/mm/numa_32.c b/arch/x86/mm/numa_32.c
> index 6b7ce62..aca6295 100644
> --- a/arch/x86/mm/numa_32.c
> +++ b/arch/x86/mm/numa_32.c
> @@ -100,5 +100,6 @@ void __init initmem_init(void)
>         printk(KERN_DEBUG "High memory starts at vaddr %08lx\n",
>                         (ulong) pfn_to_kaddr(highstart_pfn));
>
> +       __vmalloc_start_set = true;
>         setup_bootmem_allocator();
>  }
> --
> 2.7.4
>



-- 
Kees Cook
Pixel Security

  reply	other threads:[~2017-05-08 22:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-07  9:06 [mm/usercopy] 517e1fbeb6: kernel BUG at arch/x86/mm/physaddr.c:78! kernel test robot
2017-05-07 14:51 ` Kees Cook
2017-05-08 18:41   ` Laura Abbott
2017-05-08 19:15     ` Kees Cook
2017-05-08 21:23       ` [PATCH] x86/mm: Set __vmalloc_start_set in numa_32.c Laura Abbott
2017-05-08 22:28         ` Kees Cook [this message]
2017-05-09  6:40         ` [tip:x86/urgent] x86/mm/32: Set the '__vmalloc_start_set' flag in initmem_init() tip-bot for Laura Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGXu5j+E9AGn8SosiBv921gt0Te-Xh4cTr4XYh0MD-jueDnorw@mail.gmail.com \
    --to=keescook@chromium.org \
    --cc=hpa@zytor.com \
    --cc=labbott@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).