From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935303Ab2JXRZl (ORCPT ); Wed, 24 Oct 2012 13:25:41 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:44477 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932947Ab2JXRZj (ORCPT ); Wed, 24 Oct 2012 13:25:39 -0400 MIME-Version: 1.0 In-Reply-To: <20121024171723.GA7698@sergelap> References: <1351022666-6960-1-git-send-email-keescook@chromium.org> <1351022666-6960-156-git-send-email-keescook@chromium.org> <20121024134831.GB7217@sergelap> <20121024171723.GA7698@sergelap> Date: Wed, 24 Oct 2012 10:25:37 -0700 X-Google-Sender-Auth: qGcG1ANacEbEtFb2WJyWQ6wvnGI Message-ID: Subject: Re: [PATCH 155/193] init: remove CONFIG_EXPERIMENTAL From: Kees Cook To: Serge Hallyn Cc: linux-kernel@vger.kernel.org, "Eric W. Biederman" , "Paul E. McKenney" , Andrew Morton , Frederic Weisbecker Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 24, 2012 at 10:17 AM, Serge Hallyn wrote: > Quoting Kees Cook (keescook@chromium.org): >> On Wed, Oct 24, 2012 at 6:48 AM, Serge Hallyn >> wrote: >> > Quoting Kees Cook (keescook@chromium.org): >> >> This config item has not carried much meaning for a while now and is >> >> almost always enabled by default. As agreed during the Linux kernel >> >> summit, remove it. >> >> >> >> CC: "Eric W. Biederman" >> >> CC: Serge Hallyn >> >> CC: "Paul E. McKenney" >> >> CC: Andrew Morton >> >> CC: Frederic Weisbecker >> >> Signed-off-by: Kees Cook >> >> --- >> >> init/Kconfig | 23 ++++++++++------------- >> >> 1 file changed, 10 insertions(+), 13 deletions(-) >> >> >> >> diff --git a/init/Kconfig b/init/Kconfig >> >> index 2bf7b83..4b65c1c 100644 >> >> --- a/init/Kconfig >> >> +++ b/init/Kconfig >> >> @@ -220,7 +220,7 @@ config SYSVIPC_SYSCTL >> >> >> >> config POSIX_MQUEUE >> >> bool "POSIX Message Queues" >> >> - depends on NET && EXPERIMENTAL >> >> + depends on NET >> >> ---help--- >> >> POSIX variant of message queues is a part of IPC. In POSIX message >> >> queues every message has a priority which decides about succession >> >> @@ -366,7 +366,7 @@ config BSD_PROCESS_ACCT_V3 >> >> at . >> >> >> >> config TASKSTATS >> >> - bool "Export task/process statistics through netlink (EXPERIMENTAL)" >> >> + bool "Export task/process statistics through netlink" >> > >> > In these cases, should we keep the '(EXPERIMENTAL)' text since it is just >> > a hint to anyone running make menuconfig? I think removing the 'depends on >> > EXPERIMENTAL's is fine, but cases we should leave it (or replace it) as >> > a textual hint, except in cases where we're sure that is no longer the case. >> >> I covered this in the 000 intro email (https://lkml.org/lkml/2012/10/23/580): > > intro email is an appreciated courtesy, but should not take the place of > info in the individual patch changelogs, especially as the intro emails > won't go into git history. > >> Some patches remove "(EXPERIMENTAL)" from Kconfig titles when there was >> no "depends on EXPERIMENTAL". I've removed the cases of these where I > > Hm, I was under the impression that taskstats are not quite trusted yet, > but I could be way out of date with that. I'm happy to leave the taskstats title alone. Shall I? -Kees -- Kees Cook Chrome OS Security