From: Kees Cook <keescook@chromium.org>
To: Eddie Kovsky <ewk@edkovsky.org>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, Jessica Yu <jeyu@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH v5 2/2] extable: verify address is read-only
Date: Fri, 7 Apr 2017 13:45:24 -0700 [thread overview]
Message-ID: <CAGXu5j+TTp2RKsadApvVPhEGNuqfURGPXVnT_R0uKm9gZinnjQ@mail.gmail.com> (raw)
In-Reply-To: <20170407192930.GA1526@athena>
On Fri, Apr 7, 2017 at 12:29 PM, Eddie Kovsky <ewk@edkovsky.org> wrote:
> On 04/07/17, kbuild test robot wrote:
>> Hi Eddie,
>>
>> [auto build test ERROR on next-20170330]
>> [cannot apply to linus/master linux/master jeyu/modules-next v4.9-rc8 v4.9-rc7 v4.9-rc6 v4.11-rc5]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>
>> url: https://github.com/0day-ci/linux/commits/Eddie-Kovsky/module-verify-address-is-read-only/20170407-004322
>> config: i386-randconfig-x010-201714 (attached as .config)
>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>> reproduce:
>> # save the attached .config to linux build tree
>> make ARCH=i386
>>
>> All errors (new ones prefixed by >>):
>>
>> kernel/extable.c: In function 'core_kernel_rodata':
>> >> kernel/extable.c:169:29: error: '__start_ro_after_init' undeclared (first use in this function)
>> if (addr >= (unsigned long)__start_ro_after_init &&
>> ^~~~~~~~~~~~~~~~~~~~~
>> kernel/extable.c:169:29: note: each undeclared identifier is reported only once for each function it appears in
>> >> kernel/extable.c:170:28: error: '__end_ro_after_init' undeclared (first use in this function)
>> addr < (unsigned long)__end_ro_after_init)
>> ^~~~~~~~~~~~~~~~~~~
>>
>> vim +/__start_ro_after_init +169 kernel/extable.c
>>
>> 163 int core_kernel_rodata(unsigned long addr)
>> 164 {
>> 165 if (addr >= (unsigned long)__start_rodata &&
>> 166 addr < (unsigned long)__end_rodata)
>> 167 return 1;
>> 168
>> > 169 if (addr >= (unsigned long)__start_ro_after_init &&
>> > 170 addr < (unsigned long)__end_ro_after_init)
>> 171 return 1;
>> 172
>> 173 return 0;
>>
>> ---
>> 0-DAY kernel test infrastructure Open Source Technology Center
>> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
>
> This looks like a false alarm.
>
> The test build is based on next-20170330. Kees' patch for the section
> names [start|end]_ro_after_init didn't appear in next until 20170403.
>
> I cannot reproduce the build error using this config on recent versions
> of next. Am I missing something here?
I agree, this was built without the renaming from the latest -next trees.
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-04-07 20:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 3:35 [PATCH v5 0/2] provide check for ro_after_init memory sections Eddie Kovsky
2017-04-06 3:35 ` [PATCH v5 1/2] module: verify address is read-only Eddie Kovsky
2017-04-07 1:58 ` Jessica Yu
2017-04-07 20:46 ` Kees Cook
2017-04-06 3:35 ` [PATCH v5 2/2] extable: " Eddie Kovsky
2017-04-06 17:20 ` kbuild test robot
2017-04-06 17:41 ` kbuild test robot
2017-04-07 19:29 ` Eddie Kovsky
2017-04-07 20:45 ` Kees Cook [this message]
2017-04-07 21:53 ` [PATCH v5 0/2] provide check for ro_after_init memory sections Kees Cook
2017-04-07 22:12 ` Andrew Morton
2017-04-07 22:15 ` Kees Cook
2017-04-07 22:23 ` Andrew Morton
2017-04-07 22:47 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5j+TTp2RKsadApvVPhEGNuqfURGPXVnT_R0uKm9gZinnjQ@mail.gmail.com \
--to=keescook@chromium.org \
--cc=ewk@edkovsky.org \
--cc=jeyu@redhat.com \
--cc=kbuild-all@01.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).