From: Kees Cook <keescook@chromium.org>
To: Zubin Mithra <zsm@chromium.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v2] tracefs: Annotate tracefs_ops with __ro_after_init
Date: Mon, 30 Jul 2018 17:25:06 -0700 [thread overview]
Message-ID: <CAGXu5j+Zk564SijO=eXxryUTNojO7h-rgf_BuQMKesWb+zPOJg@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5jJhgbDYK4ZQtkZtpNPMMYwz-iH4224eULmLDdrvp-s4BA@mail.gmail.com>
On Wed, Jul 25, 2018 at 11:00 AM, Kees Cook <keescook@chromium.org> wrote:
> On Wed, Jul 25, 2018 at 10:19 AM, Zubin Mithra <zsm@chromium.org> wrote:
>> tracefs_ops is initialized inside tracefs_create_instance_dir and not
>> modified after. tracefs_create_instance_dir allows for initialization
>> only once, and is called from create_trace_instances(marked __init),
>> which is called from tracer_init_tracefs(marked __init). Also, mark
>> tracefs_create_instance_dir as __init.
>>
>> Signed-off-by: Zubin Mithra <zsm@chromium.org>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Steve, do you have a tree for this or should we rope akpm in? :)
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2018-07-31 0:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 17:19 [PATCH v2] tracefs: Annotate tracefs_ops with __ro_after_init Zubin Mithra
2018-07-25 18:00 ` Kees Cook
2018-07-31 0:25 ` Kees Cook [this message]
2018-07-31 15:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5j+Zk564SijO=eXxryUTNojO7h-rgf_BuQMKesWb+zPOJg@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zsm@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).