From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753807AbdBVFII (ORCPT ); Wed, 22 Feb 2017 00:08:08 -0500 Received: from mail-it0-f48.google.com ([209.85.214.48]:37365 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbdBVFIB (ORCPT ); Wed, 22 Feb 2017 00:08:01 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170221201656.GA52020@beast> From: Kees Cook Date: Tue, 21 Feb 2017 21:07:59 -0800 X-Google-Sender-Auth: hG7yJMsl3pORAdV6WvKPrNPNcW4 Message-ID: Subject: Re: [GIT PULL] gcc-plugins updates for v4.11-rc1 To: Linus Torvalds Cc: Linux Kernel Mailing List , Emese Revfy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 21, 2017 at 6:34 PM, Linus Torvalds wrote: > On Tue, Feb 21, 2017 at 12:16 PM, Kees Cook wrote: >> >> Please pull these gcc-plugins changes for v4.11-rc1. This includes two new >> plugins for the upstream kernel: structleak and initify. The structleak >> plugin performs forced initialization of certain structures to avoid >> possible information exposures to userspace. The initify plugin performs >> analysis to find functions and strings that can be marked as __init or >> __exit to reduce the runtime size of the kernel. > > I pulled this, but then looked at the patch, and decided to unpull it. Hrm, I will send a pull for just the infrastructure and structleak changes, since those are independent from the initify changes. > The crazy "__nocapture()" annotations are too ugly to live, and make > no sense. They are basically random noise to some very core header > files. And the "__unverified_nocapture()" ones are worse. Is it the naming, or something else? I tried to document them as clearly as I could... the initify plugin needs to figure out if a string is being retained by a function to decide if it can safely be moved into the .init section. > I'm not sure how to fix this issue. I'm open to ideas. :) Initify certainly has more annotations than most of the pending plugins, but there needs to be a way to mark things for plugin consumption. -Kees -- Kees Cook Pixel Security