From: Kees Cook <keescook@chromium.org>
To: efremov@linux.com
Cc: James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Eric Paris <eparis@redhat.com>, Paul Moore <paul@paul-moore.com>,
John Johansen <john.johansen@canonical.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/9] security: fix documentation for the socket_post_create hook
Date: Tue, 23 Oct 2018 12:28:01 -0700 [thread overview]
Message-ID: <CAGXu5j+nJM6RWZJZNBsvVSbS7=UkyGFEnO_rM+phFtLvxYuRYA@mail.gmail.com> (raw)
In-Reply-To: <20181023110837.27840-1-efremov@linux.com>
On Tue, Oct 23, 2018 at 4:08 AM, <efremov@linux.com> wrote:
> From: Denis Efremov <efremov@linux.com>
>
> This patch slightly fixes the documentation for the
> socket_post_create hook. The documentation states that
> i_security field is accessible through inode field of socket
> structure (i.e., 'sock->inode->i_security'). There is no inode
> field in the socket structure. The i_security field is accessible
> through SOCK_INODE macro. The patch fixes the documentation accordingly.
>
> Signed-off-by: Denis Efremov <efremov@linux.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> include/linux/lsm_hooks.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index 8f84ef819e00..accf6f34ac8e 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -752,9 +752,9 @@
> * socket structure, but rather, the socket security information is stored
> * in the associated inode. Typically, the inode alloc_security hook will
> * allocate and and attach security information to
> - * sock->inode->i_security. This hook may be used to update the
> - * sock->inode->i_security field with additional information that wasn't
> - * available when the inode was allocated.
> + * SOCK_INODE(sock)->i_security. This hook may be used to update the
> + * SOCK_INODE(sock)->i_security field with additional information that
> + * wasn't available when the inode was allocated.
> * @sock contains the newly created socket structure.
> * @family contains the requested protocol family.
> * @type contains the requested communications type.
> --
> 2.17.2
>
--
Kees Cook
prev parent reply other threads:[~2018-10-23 19:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 11:08 [PATCH 3/9] security: fix documentation for the socket_post_create hook efremov
2018-10-23 19:28 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5j+nJM6RWZJZNBsvVSbS7=UkyGFEnO_rM+phFtLvxYuRYA@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=efremov@linux.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).