linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] compat: Mark expected switch fall-throughs
Date: Mon, 15 Oct 2018 14:30:06 -0700	[thread overview]
Message-ID: <CAGXu5j+p-UivAA8_6Mu0s_uL5mOY0fhxskqnyPSY2+2PL8+i4Q@mail.gmail.com> (raw)
In-Reply-To: <20181013115048.GA3262@embeddedor.com>

On Sat, Oct 13, 2018 at 4:50 AM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Acked-by: Kees Cook <keescook@chromium.org>

-Kees

> ---
>  include/linux/compat.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/compat.h b/include/linux/compat.h
> index d30e4db..06e7747 100644
> --- a/include/linux/compat.h
> +++ b/include/linux/compat.h
> @@ -488,8 +488,11 @@ put_compat_sigset(compat_sigset_t __user *compat, const sigset_t *set,
>         compat_sigset_t v;
>         switch (_NSIG_WORDS) {
>         case 4: v.sig[7] = (set->sig[3] >> 32); v.sig[6] = set->sig[3];
> +               /* fall through */
>         case 3: v.sig[5] = (set->sig[2] >> 32); v.sig[4] = set->sig[2];
> +               /* fall through */
>         case 2: v.sig[3] = (set->sig[1] >> 32); v.sig[2] = set->sig[1];
> +               /* fall through */
>         case 1: v.sig[1] = (set->sig[0] >> 32); v.sig[0] = set->sig[0];
>         }
>         return copy_to_user(compat, &v, size) ? -EFAULT : 0;
> --
> 2.7.4
>



-- 
Kees Cook
Pixel Security

      reply	other threads:[~2018-10-15 21:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-13 11:50 [PATCH] compat: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-10-15 21:30 ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGXu5j+p-UivAA8_6Mu0s_uL5mOY0fhxskqnyPSY2+2PL8+i4Q@mail.gmail.com \
    --to=keescook@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).