From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757830AbcJXXRi (ORCPT <rfc822;w@1wt.eu>);
        Mon, 24 Oct 2016 19:17:38 -0400
Received: from mail-wm0-f51.google.com ([74.125.82.51]:36764 "EHLO
        mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753901AbcJXXRf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 24 Oct 2016 19:17:35 -0400
MIME-Version: 1.0
In-Reply-To: <20161020224521.GA24970@obsidianresearch.com>
References: <20161003161322.3835-1-dvlasenk@redhat.com> <CAGXu5j+haCUW_AEPLPcVGtrnv4ojQ79FDpspUurYJSX_-TXeow@mail.gmail.com>
 <877f9p55lu.fsf@concordia.ellerman.id.au> <CAGXu5jJ3PpvNBYyBWa_M8ELLPuJOcJt-KuH0uRK66peJM_CnSg@mail.gmail.com>
 <20161020224521.GA24970@obsidianresearch.com>
From: Kees Cook <keescook@chromium.org>
Date: Mon, 24 Oct 2016 16:17:33 -0700
X-Google-Sender-Auth: KEPF54_NhEf_muFefhbAqVE74rg
Message-ID: <CAGXu5j+uQqgZSv3fyo+_5z7u9CC=2KjtcAiP6bQkzi9ZK6XLww@mail.gmail.com>
Subject: Re: [PATCH v6] powerpc: Do not make the entire heap executable
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
        Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        Oleg Nesterov <oleg@redhat.com>, Florian Weimer <fweimer@redhat.com>,
        Linux-MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 20, 2016 at 3:45 PM, Jason Gunthorpe
<jgunthorpe@obsidianresearch.com> wrote:
> On Tue, Oct 04, 2016 at 09:54:12AM -0700, Kees Cook wrote:
>> On Mon, Oct 3, 2016 at 5:18 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> > Kees Cook <keescook@chromium.org> writes:
>> >
>> >> On Mon, Oct 3, 2016 at 9:13 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
>> >>> On 32-bit powerpc the ELF PLT sections of binaries (built with --bss-plt,
>> >>> or with a toolchain which defaults to it) look like this:
>> > ...
>> >>>
>> >>> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>> >>> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
>> >>> Acked-by: Kees Cook <keescook@chromium.org>
>> >>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>> >>> CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>> >>> CC: Paul Mackerras <paulus@samba.org>
>> >>> CC: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>> >>> CC: Kees Cook <keescook@chromium.org>
>> >>> CC: Oleg Nesterov <oleg@redhat.com>
>> >>> CC: Michael Ellerman <mpe@ellerman.id.au>
>> >>> CC: Florian Weimer <fweimer@redhat.com>
>> >>> CC: linux-mm@kvack.org
>> >>> CC: linuxppc-dev@lists.ozlabs.org
>> >>> CC: linux-kernel@vger.kernel.org
>> >>> Changes since v5:
>> >>> * made do_brk_flags() error out if any bits other than VM_EXEC are set.
>> >>>   (Kees Cook: "With this, I'd be happy to Ack.")
>> >>>   See https://patchwork.ozlabs.org/patch/661595/
>> >>
>> >> Excellent, thanks for the v6! Should this go via the ppc tree or the -mm tree?
>> >
>> > -mm would be best, given the diffstat I think it's less likely to
>> >  conflict if it goes via -mm.
>>
>> Okay, excellent. Andrew, do you have this already in email? I think
>> you weren't on the explicit CC from the v6...
>
> FWIW (and ping),
>
> Tested-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
>
> On ARM32 (kirkwood) and PPC32 (405)
>
> For reference, here is the patchwork URL:
>
> https://patchwork.ozlabs.org/patch/677753/

Hi Andrew,

Can you pick this up?

Thanks!

-Kees

-- 
Kees Cook
Nexus Security