From: Kees Cook <keescook@chromium.org>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"varun@chelsio.com" <varun@chelsio.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"jiangyilism@gmail.com" <jiangyilism@gmail.com>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Subject: Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()
Date: Mon, 30 Oct 2017 17:04:48 -0700 [thread overview]
Message-ID: <CAGXu5j+z9t28n33e6r9hxRNX1hpkzF4Z5sy308sWYh84whkRfQ@mail.gmail.com> (raw)
In-Reply-To: <1509109031.3135.1.camel@wdc.com>
On Fri, Oct 27, 2017 at 5:57 AM, Bart Van Assche <Bart.VanAssche@wdc.com> wrote:
> On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly. Includes a fix for correcting an
>> on-stack timer usage.
>
> Hello Kees,
>
> These changes look good to me but I would like to test this patch. Is there
> a tree available somewhere that includes this patch?
I didn't, but in case it's easier to test, I have put it up here,
which is just tip/timers/core with the two target timer patches on
top:
https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=kspp/timer/tip/target
Thanks!
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-10-31 0:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-27 9:19 [PATCH v2] target/iscsi: Convert timers to use timer_setup() Kees Cook
2017-10-27 12:57 ` Bart Van Assche
2017-10-31 0:04 ` Kees Cook [this message]
2017-10-31 17:16 ` Bart Van Assche
2017-10-31 17:20 ` Martin K. Petersen
2017-10-31 17:34 ` Bart Van Assche
2017-10-31 17:42 ` Martin K. Petersen
2017-10-31 18:12 ` Kees Cook
2017-10-31 18:13 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5j+z9t28n33e6r9hxRNX1hpkzF4Z5sy308sWYh84whkRfQ@mail.gmail.com \
--to=keescook@chromium.org \
--cc=Bart.VanAssche@wdc.com \
--cc=jiangyilism@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).