From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752490AbdGIOCu (ORCPT ); Sun, 9 Jul 2017 10:02:50 -0400 Received: from mail-it0-f53.google.com ([209.85.214.53]:37806 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbdGIOCt (ORCPT ); Sun, 9 Jul 2017 10:02:49 -0400 MIME-Version: 1.0 In-Reply-To: <1499603862-11516-4-git-send-email-bhe@redhat.com> References: <1499603862-11516-1-git-send-email-bhe@redhat.com> <1499603862-11516-4-git-send-email-bhe@redhat.com> From: Kees Cook Date: Sun, 9 Jul 2017 07:02:47 -0700 X-Google-Sender-Auth: Af693z51Gv33GCGV5iEh-ueK7Xs Message-ID: Subject: Re: [PATCH v4 3/4] x86/boot/KASLR: Rename process_e820_entry() into process_mem_region() To: Baoquan He Cc: LKML , "x86@kernel.org" , Matt Fleming , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , izumi.taku@jp.fujitsu.com, fanc.fnst@cn.fujitsu.com, Thomas Garnier Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 9, 2017 at 5:37 AM, Baoquan He wrote: > Now process_e820_entry() is not limited to e820 entry processing, rename > it to process_mem_region(). And adjust the code comment accordingly. > > Signed-off-by: Baoquan He Acked-by: Kees Cook -Kees > --- > arch/x86/boot/compressed/kaslr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c > index 36ff9f729c43..99c7194f7ea6 100644 > --- a/arch/x86/boot/compressed/kaslr.c > +++ b/arch/x86/boot/compressed/kaslr.c > @@ -479,7 +479,7 @@ static unsigned long slots_fetch_random(void) > return 0; > } > > -static void process_e820_entry(struct mem_vector *entry, > +static void process_mem_region(struct mem_vector *entry, > unsigned long minimum, > unsigned long image_size) > { > @@ -517,7 +517,7 @@ static void process_e820_entry(struct mem_vector *entry, > /* Potentially raise address to meet alignment needs. */ > region.start = ALIGN(region.start, CONFIG_PHYSICAL_ALIGN); > > - /* Did we raise the address above this e820 region? */ > + /* Did we raise the address above the passed in memory entry? */ > if (region.start > cur_entry.start + cur_entry.size) > return; > > @@ -573,7 +573,7 @@ static void process_e820_entries(unsigned long minimum, > continue; > region.start = entry->addr; > region.size = entry->size; > - process_e820_entry(®ion, minimum, image_size); > + process_mem_region(®ion, minimum, image_size); > if (slot_area_index == MAX_SLOT_AREA) { > debug_putstr("Aborted e820 scan (slot_areas full)!\n"); > break; > -- > 2.5.5 > -- Kees Cook Pixel Security