From: Kees Cook <keescook@chromium.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Daniel Micay <danielmicay@gmail.com>,
Bhupesh Sharma <bhsharma@redhat.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
Bhupesh SHARMA <bhupesh.linux@gmail.com>,
Anton Blanchard <anton@samba.org>,
Daniel Cashman <dcashman@android.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [kernel-hardening] [PATCH] powerpc: Increase ELF_ET_DYN_BASE to 1TB for 64-bit applications
Date: Wed, 7 Jun 2017 11:29:32 -0700 [thread overview]
Message-ID: <CAGXu5jJE84GP8JCwtxKEp5Q_d0oVDScku4XJf7sAG2TPthVyZQ@mail.gmail.com> (raw)
In-Reply-To: <87d1agp2m6.fsf@concordia.ellerman.id.au>
On Wed, Jun 7, 2017 at 2:29 AM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> Daniel Micay <danielmicay@gmail.com> writes:
>
>> Rather than doing this, the base should just be split for an ELF
>> interpreter like PaX.
>
> I don't quite parse that, I think you mean PaX uses a different base for
> an ELF interpreter vs a regular ET_DYN?
>
> That would be cool. How do you know that it's an ELF interpreter you're
> loading? Is it just something that's PIE but doesn't request an
> interpreter?
I talk a bit about the situation here:
http://www.openwall.com/lists/kernel-hardening/2017/06/03/6
> Is the PaX code somewhere I can look at?
It's near here:
https://github.com/linux-scraping/linux-grsecurity/blob/grsec-test/fs/binfmt_elf.c#L1362
(Note the "&& elf_interpreter" part.) It's replacing the
arch_rnd_mmap() result with its own under some situations, etc.
To do something like this in upstream, we need to be sure we've sanely
dealt with the brk region, which follows the first loaded ELF, and if
it's the interpreter, that means brk ends up in mmap area, up near the
executable area (near what would become the misnomer of
ELF_ET_DYN_BASE -- should be ELF_PIE_BASE).
-Kees
--
Kees Cook
Pixel Security
prev parent reply other threads:[~2017-06-07 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-05 6:03 [PATCH] powerpc: Increase ELF_ET_DYN_BASE to 1TB for 64-bit applications Bhupesh Sharma
2017-06-05 12:22 ` [kernel-hardening] " Daniel Micay
2017-06-07 9:29 ` Michael Ellerman
2017-06-07 10:34 ` Bhupesh SHARMA
2017-06-07 18:29 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jJE84GP8JCwtxKEp5Q_d0oVDScku4XJf7sAG2TPthVyZQ@mail.gmail.com \
--to=keescook@chromium.org \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=bhsharma@redhat.com \
--cc=bhupesh.linux@gmail.com \
--cc=danielmicay@gmail.com \
--cc=dcashman@android.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).