From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751793AbeDMUlj (ORCPT ); Fri, 13 Apr 2018 16:41:39 -0400 Received: from mail-ua0-f173.google.com ([209.85.217.173]:45959 "EHLO mail-ua0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbeDMUlh (ORCPT ); Fri, 13 Apr 2018 16:41:37 -0400 X-Google-Smtp-Source: AIpwx48Wc1PNdUJFLDK60g7VMXdxEI63YOO2SElj3lOgNOlu2GyJ/1C4GnwKTpU10Ky8/s14VbUF1tG1ojvbyrRuMmc= MIME-Version: 1.0 In-Reply-To: References: <1523595999-27433-1-git-send-email-yamada.masahiro@socionext.com> <1523595999-27433-22-git-send-email-yamada.masahiro@socionext.com> From: Kees Cook Date: Fri, 13 Apr 2018 13:41:35 -0700 X-Google-Sender-Auth: kfB4AthzXbRDt3EdvJ53zm4T01A Message-ID: Subject: Re: [PATCH 21/30] stack-protector: test compiler capability in Kconfig and drop AUTO mode To: Linus Torvalds Cc: Masahiro Yamada , linux-kbuild , Sam Ravnborg , Ulf Magnusson , Nicholas Piggin , Emese Revfy , X86 ML , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 13, 2018 at 11:11 AM, Linus Torvalds wrote: > config STACKPROTECTOR_FLAGS > string > default "-fstack-protector-strong" if CC_STACKPROTECTOR_STRONG > default "-fstack-protector" if CC_STACKPROTECTOR > default "-fno-stack-protector" if CC_HAS_STACKPROTECTOR_NONE > default "" > > which is really simple and straightforward. In the presense of > multiple defaults, the first is picked, so this _automatically_ does > that whole priority ordering. Ah, perfect! Yes, this is a much better solution. -Kees -- Kees Cook Pixel Security