From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932784AbdJ3VUM (ORCPT ); Mon, 30 Oct 2017 17:20:12 -0400 Received: from mail-io0-f181.google.com ([209.85.223.181]:53271 "EHLO mail-io0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932341AbdJ3VUI (ORCPT ); Mon, 30 Oct 2017 17:20:08 -0400 X-Google-Smtp-Source: ABhQp+SGhgkMojHRFxKTCP64AKjPqDjLLLZUVweBoOFJWVD815Uq06nQBYu1/TqpHM/wvl0DBxECDhB4zBqbOv970lI= MIME-Version: 1.0 In-Reply-To: <1508292283-140003-1-git-send-email-keescook@chromium.org> References: <1508292283-140003-1-git-send-email-keescook@chromium.org> From: Kees Cook Date: Mon, 30 Oct 2017 14:20:06 -0700 X-Google-Sender-Auth: 1M3tdf3K2_t_wIHUO8VZRU9fsMY Message-ID: Subject: Re: [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param_call() To: Jessica Yu Cc: Arnd Bergmann , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 17, 2017 at 7:04 PM, Kees Cook wrote: > (re-sending to Jessica's @korg address...) > > The module_param_call() macro was explicitly casting the .set and .get > function prototypes away with (void *). This can lead to hard-to-find > type mismatches. Additionally, it creates problems for static checkers > and Control Flow Itegrity compiler features, which depend on clustering > function call sites based on prototype signature. > > This removes the casts and fixes all the incorrect prototypes tree-wide. A quick ping on this. I'd really like to land this in 4.15, as it's relatively trivial. How does this look to you Jessica? -Kees -- Kees Cook Pixel Security