From: Kees Cook <keescook@chromium.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Guodong Xu <guodong.xu@linaro.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Wei Xu <xuwei5@hisilicon.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/4] arm64: dts: hikey: Add pstore support for HiKey
Date: Thu, 8 Sep 2016 17:12:45 -0700 [thread overview]
Message-ID: <CAGXu5jJjEchF8MxE5vhLEj9wy1NcibLR88YptGm3uG79DD-sxA@mail.gmail.com> (raw)
In-Reply-To: <1471906085-16682-4-git-send-email-john.stultz@linaro.org>
On Mon, Aug 22, 2016 at 3:48 PM, John Stultz <john.stultz@linaro.org> wrote:
> This patch reserves some memory in the DTS and sets up a
> pstore device tree node to enable pstore support on HiKey.
>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Guodong Xu <guodong.xu@linaro.org>
> Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: devicetree@vger.kernel.org
> Reviewed-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: John Stultz <john.stultz@linaro.org>
I'm going through old emails -- did this get picked up by anyone? I
don't see an "applied" reply or similar, though I could have easily
missed it. :)
-Kees
> ---
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 19 ++++++++++++++++++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> index 4492a15..9508f28 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts
> @@ -32,6 +32,7 @@
> * 0x05f0,1000 - 0x05f0,1fff: Reboot reason
> * 0x06df,f000 - 0x06df,ffff: Mailbox message data
> * 0x0740,f000 - 0x0740,ffff: MCU firmware section
> + * 0x21f0,0000 - 0x21ff,ffff: pstore/ramoops buffer
> * 0x3e00,0000 - 0x3fff,ffff: OP-TEE
> */
> memory@0 {
> @@ -40,9 +41,25 @@
> <0x00000000 0x05f00000 0x00000000 0x00001000>,
> <0x00000000 0x05f02000 0x00000000 0x00efd000>,
> <0x00000000 0x06e00000 0x00000000 0x0060f000>,
> - <0x00000000 0x07410000 0x00000000 0x36bf0000>;
> + <0x00000000 0x07410000 0x00000000 0x1aaf0000>,
> + <0x00000000 0x22000000 0x00000000 0x1c000000>;
> };
>
> + reserved-memory {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + ramoops@0x21f00000 {
> + compatible = "ramoops";
> + reg = <0x0 0x21f00000 0x0 0x00100000>;
> + record-size = <0x00020000>;
> + console-size = <0x00020000>;
> + ftrace-size = <0x00020000>;
> + };
> + };
> +
> +
> reboot-mode-syscon@5f01000 {
> compatible = "syscon", "simple-mfd";
> reg = <0x0 0x05f01000 0x0 0x00001000>;
> --
> 1.9.1
>
--
Kees Cook
Nexus Security
next prev parent reply other threads:[~2016-09-09 0:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-22 22:48 [PATCH 1/4] arm64: dts: Add display subsystem DT nodes for hi6220-hikey John Stultz
2016-08-22 22:48 ` [PATCH 2/4] arm64: dts: Add HDMI node " John Stultz
2016-08-22 22:48 ` [PATCH 3/4] arm64: dts: hikey: Add hikey support for syscon-reboot-mode John Stultz
2016-08-22 22:48 ` [PATCH 4/4] arm64: dts: hikey: Add pstore support for HiKey John Stultz
2016-09-09 0:12 ` Kees Cook [this message]
2016-09-09 0:17 ` John Stultz
2016-09-09 8:31 ` Wei Xu
2016-08-24 15:14 ` [PATCH 1/4] arm64: dts: Add display subsystem DT nodes for hi6220-hikey Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jJjEchF8MxE5vhLEj9wy1NcibLR88YptGm3uG79DD-sxA@mail.gmail.com \
--to=keescook@chromium.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=guodong.xu@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).