From: Kees Cook <keescook@chromium.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Eric Paris <eparis@redhat.com>,
libseccomp-discuss@lists.sourceforge.net,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Will Drewry <wad@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] seccomp: not compatible with ARM OABI
Date: Thu, 7 Nov 2013 09:26:45 -0800 [thread overview]
Message-ID: <CAGXu5jJn3jJs+mB76ZxOu_ibXuo9Q3mVeKjruZsJRRKpuUJd3A@mail.gmail.com> (raw)
In-Reply-To: <527B72AF.50002@imgtec.com>
On Thu, Nov 7, 2013 at 2:59 AM, James Hogan <james.hogan@imgtec.com> wrote:
> Hi,
>
> On 06/11/13 23:31, Kees Cook wrote:
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index af2cc6eabcc7..6eaca7d92399 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -331,12 +331,15 @@ config HAVE_ARCH_SECCOMP_FILTER
>>
>> config SECCOMP_FILTER
>> def_bool y
>> - depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET
>> + depends on HAVE_ARCH_SECCOMP_FILTER && SECCOMP && NET && !OABI_COMPAT
>
> Isn't this the whole point of HAVE_ARCH_SECCOMP_FILTER?
>
> Just change the select in arch/arm/Kconfig to this:
>
> select HAVE_ARCH_SECCOMP_FILTER if !OABI_COMPAT
Oh! Yeah, that's a much cleaner way to handle it. I totally forgot
that "select" could be conditional. I will respin it that way.
Thanks!
-Kees
--
Kees Cook
Chrome OS Security
prev parent reply other threads:[~2013-11-07 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-06 23:31 [PATCH] seccomp: not compatible with ARM OABI Kees Cook
2013-11-07 3:26 ` Will Drewry
2013-11-07 10:59 ` James Hogan
2013-11-07 17:26 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jJn3jJs+mB76ZxOu_ibXuo9Q3mVeKjruZsJRRKpuUJd3A@mail.gmail.com \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=libseccomp-discuss@lists.sourceforge.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=luto@amacapital.net \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).