From: Kees Cook <keescook@chromium.org>
To: Joel Fernandes <joelaf@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 3/7] pstore: Remove case of PSTORE_TYPE_PMSG write using deprecated function
Date: Mon, 10 Oct 2016 16:52:43 -0700 [thread overview]
Message-ID: <CAGXu5jK--iZCVpQhFwWC2wU8yF-uot_zemtC8n7LxysFBthHJg@mail.gmail.com> (raw)
In-Reply-To: <1475904515-24970-4-git-send-email-joelaf@google.com>
On Fri, Oct 7, 2016 at 10:28 PM, Joel Fernandes <joelaf@google.com> wrote:
> PMSG now uses ramoops_pstore_write_buf_user instead of ramoops_pstore_write_buf
> Remove the case where we check PSTORE_TYPE_PMSG case.
Ah yeah, good point. Can you actually improve this to add a
ratelimited WARN() to both _write_buf and write_buf_user when an
unhandled type is encountered?
-Kees
>
> Signed-off-by: Joel Fernandes <joelaf@google.com>
> ---
> fs/pstore/ram.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index 751197d..519404c 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -287,11 +287,6 @@ static int notrace ramoops_pstore_write_buf(enum pstore_type_id type,
> return -ENOMEM;
> persistent_ram_write(cxt->fprz, buf, size, 1);
> return 0;
> - } else if (type == PSTORE_TYPE_PMSG) {
> - if (!cxt->mprz)
> - return -ENOMEM;
> - persistent_ram_write(cxt->mprz, buf, size, 1);
> - return 0;
> }
>
> if (type != PSTORE_TYPE_DMESG)
> --
> 2.7.4
>
--
Kees Cook
Nexus Security
next prev parent reply other threads:[~2016-10-10 23:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 5:28 [RFC 0/7] pstore: Improve performance of ftrace backend with ramoops Joel Fernandes
2016-10-08 5:28 ` [PATCH 1/7] pstore: Make spinlock per zone instead of global Joel Fernandes
2016-10-08 5:44 ` Joel Fernandes
2016-10-10 23:44 ` Kees Cook
2016-10-08 5:28 ` [PATCH 2/7] pstore: locking: dont lock unless caller asks to Joel Fernandes
2016-10-10 23:48 ` Kees Cook
2016-10-11 14:41 ` Joel Fernandes
2016-10-08 5:28 ` [PATCH 3/7] pstore: Remove case of PSTORE_TYPE_PMSG write using deprecated function Joel Fernandes
2016-10-10 23:52 ` Kees Cook [this message]
2016-10-11 14:46 ` Joel Fernandes
2016-10-08 5:28 ` [PATCH 4/7] pstore: Make ramoops_init_przs generic for other prz arrays Joel Fernandes
2016-10-10 23:55 ` Kees Cook
2016-10-08 5:28 ` [PATCH 5/7] ramoops: Split ftrace buffer space into per-CPU zones Joel Fernandes
2016-10-09 17:15 ` Joel Fernandes
2016-10-10 23:59 ` Kees Cook
2016-10-11 0:00 ` Kees Cook
2016-10-16 17:40 ` Joel Fernandes
2016-10-18 20:37 ` Kees Cook
2016-10-08 5:28 ` [PATCH 6/7] pstore: Add support to store timestamp counter in ftrace records Joel Fernandes
2016-10-08 5:28 ` [PATCH 7/7] pstore: Merge per-CPU ftrace zones into one zone for output Joel Fernandes
2016-10-11 9:57 ` [RFC 0/7] pstore: Improve performance of ftrace backend with ramoops Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jK--iZCVpQhFwWC2wU8yF-uot_zemtC8n7LxysFBthHJg@mail.gmail.com \
--to=keescook@chromium.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).