From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67358C43381 for ; Thu, 21 Feb 2019 07:00:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F4AE2084F for ; Thu, 21 Feb 2019 07:00:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FJ42sFKb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726621AbfBUHAp (ORCPT ); Thu, 21 Feb 2019 02:00:45 -0500 Received: from mail-ua1-f67.google.com ([209.85.222.67]:42185 "EHLO mail-ua1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbfBUHAp (ORCPT ); Thu, 21 Feb 2019 02:00:45 -0500 Received: by mail-ua1-f67.google.com with SMTP id d21so9129754uap.9 for ; Wed, 20 Feb 2019 23:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=q9OR+366B5hz9/K05pp1Ilce+YyZ9pQ17esvkOO9aIU=; b=FJ42sFKbiswaF4LEj3/pf7kDORFC4l2c0nvgm+NSQrmWNLtcqtoeWfkEZ36pXsCPmc oiLyzioc83Wf/YblpbzuGBk9c3xfIVlI1LCwMQbT/GJyPMR24ne8gbX76h7+ZGGcXF/N vPcPm1NWcX9pGtbz2kbDEtLhaWD4q5wX0ZqEg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=q9OR+366B5hz9/K05pp1Ilce+YyZ9pQ17esvkOO9aIU=; b=hegbMpvqEdYfACq4vsgB18O5xFlokStM3tUIUG5U5KGhCMv+rDkNkg6ANPOmc12Yhd rOnpvw/V7LjD/tFODZCl6k7C5tYvzlYX9PPU264WNBQpm5YhWb3RPXno5wb8XPUwzgEX 92URELVqbzSVbHRJjI4dY8g+nBIAIrRRO1Wi1R8BxBqtvOjFb0+Tbm6ugXnyRXR/APMD tCboRXndkZlqZvxvl6IxQ182a+6FP5+18Agzp74O4eJbX70VZVvSwCOhdZZegJRO/jyY 5HzHlBzVqUP2VEBLZhn/nWskU33UYJDrj+4kkJGoNNccNE7LJ4tQ8e6Ma2sxByGcKbds Z2TQ== X-Gm-Message-State: AHQUAubOlp88Mtblk045Lqm8wxEiDeV1H+WLZcXIPAr22R+Niwic9KMN oVcnOiF6BaTv1akGZ01pgj+JknFjn2w= X-Google-Smtp-Source: AHgI3Iab/hcvnLJS639wdoO9czK570fceq+vlsa1/awOzdDvHdoxdRKnT+mHVaPNv/ybIK9/mCCLJw== X-Received: by 2002:ab0:20d8:: with SMTP id z24mr20912750ual.26.1550732443366; Wed, 20 Feb 2019 23:00:43 -0800 (PST) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com. [209.85.217.47]) by smtp.gmail.com with ESMTPSA id r202sm4494150vke.12.2019.02.20.23.00.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Feb 2019 23:00:42 -0800 (PST) Received: by mail-vs1-f47.google.com with SMTP id h132so3763266vsd.5 for ; Wed, 20 Feb 2019 23:00:41 -0800 (PST) X-Received: by 2002:a67:fa45:: with SMTP id j5mr4115107vsq.48.1550732441514; Wed, 20 Feb 2019 23:00:41 -0800 (PST) MIME-Version: 1.0 References: <20190221020633.GA4195@embeddedor> In-Reply-To: <20190221020633.GA4195@embeddedor> From: Kees Cook Date: Wed, 20 Feb 2019 23:00:29 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] iio: cros_ec_accel_legacy: Refactor code in cros_ec_accel_legacy_probe To: "Gustavo A. R. Silva" Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Benson Leung , Enric Balletbo i Serra , Guenter Roeck , linux-iio@vger.kernel.org, LKML , Gwendal Grignou Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 20, 2019 at 6:06 PM Gustavo A. R. Silva wrote: > > Refactor some code in order to fix both the technical implementation > and the following warnings: > > drivers/iio/accel/cros_ec_accel_legacy.c: In function =E2=80=98cros_ec_ac= cel_legacy_probe=E2=80=99: > drivers/iio/accel/cros_ec_accel_legacy.c:387:36: warning: this statement = may fall through [-Wimplicit-fallthrough=3D] > ec_accel_channels[X].scan_index =3D Y; > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ > drivers/iio/accel/cros_ec_accel_legacy.c:388:3: note: here > case Y: > ^~~~ > drivers/iio/accel/cros_ec_accel_legacy.c:389:36: warning: this statement = may fall through [-Wimplicit-fallthrough=3D] > ec_accel_channels[Y].scan_index =3D X; > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ > drivers/iio/accel/cros_ec_accel_legacy.c:390:3: note: here > case Z: > ^~~~ > > Notice that neither the for loop nor the switch statement is needed. > Also, "state->sign[Y] =3D 1" should be unconditional. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Kees Cook -Kees > --- > drivers/iio/accel/cros_ec_accel_legacy.c | 27 +++++++++++------------- > 1 file changed, 12 insertions(+), 15 deletions(-) > > diff --git a/drivers/iio/accel/cros_ec_accel_legacy.c b/drivers/iio/accel= /cros_ec_accel_legacy.c > index 063e89eff791..021f9f5cd3bb 100644 > --- a/drivers/iio/accel/cros_ec_accel_legacy.c > +++ b/drivers/iio/accel/cros_ec_accel_legacy.c > @@ -353,7 +353,7 @@ static int cros_ec_accel_legacy_probe(struct platform= _device *pdev) > struct cros_ec_sensor_platform *sensor_platform =3D dev_get_platd= ata(dev); > struct iio_dev *indio_dev; > struct cros_ec_accel_legacy_state *state; > - int ret, i; > + int ret; > > if (!ec || !ec->ec_dev) { > dev_warn(&pdev->dev, "No EC device found.\n"); > @@ -381,20 +381,17 @@ static int cros_ec_accel_legacy_probe(struct platfo= rm_device *pdev) > * Present the channel using HTML5 standard: > * need to invert X and Y and invert some lid axis. > */ > - for (i =3D X ; i < MAX_AXIS; i++) { > - switch (i) { > - case X: > - ec_accel_channels[X].scan_index =3D Y; > - case Y: > - ec_accel_channels[Y].scan_index =3D X; > - case Z: > - ec_accel_channels[Z].scan_index =3D Z; > - } > - if (state->sensor_num =3D=3D MOTIONSENSE_LOC_LID && i != =3D Y) > - state->sign[i] =3D -1; > - else > - state->sign[i] =3D 1; > - } > + ec_accel_channels[X].scan_index =3D Y; > + ec_accel_channels[Y].scan_index =3D X; > + ec_accel_channels[Z].scan_index =3D Z; > + > + state->sign[Y] =3D 1; > + > + if (state->sensor_num =3D=3D MOTIONSENSE_LOC_LID) > + state->sign[X] =3D state->sign[Z] =3D -1; > + else > + state->sign[X] =3D state->sign[Z] =3D 1; > + > indio_dev->num_channels =3D ARRAY_SIZE(ec_accel_channels); > indio_dev->dev.parent =3D &pdev->dev; > indio_dev->info =3D &cros_ec_accel_legacy_info; > -- > 2.20.1 > --=20 Kees Cook