From: Kees Cook <keescook@chromium.org>
To: Tycho Andersen <tycho@tycho.ws>
Cc: Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
James Morris <jmorris@namei.org>, Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] samples/seccomp: fix 32-bit build
Date: Mon, 7 Jan 2019 15:18:27 -0800 [thread overview]
Message-ID: <CAGXu5jK1pY-RqB_J5_obMDaWav8cJHjXQkpz0B4cHM=A8Ztq7w@mail.gmail.com> (raw)
In-Reply-To: <20190107231631.1849-1-tycho@tycho.ws>
On Mon, Jan 7, 2019 at 3:16 PM Tycho Andersen <tycho@tycho.ws> wrote:
>
> Both the .o and the actual executable need to be built with -m32 in order
> to link correctly.
>
> Signed-off-by: Tycho Andersen <tycho@tycho.ws>
> Reported-by: Ingo Molnar <mingo@kernel.org>
> Fixes: fec7b6690541 ("samples: add an example of seccomp user trap")
Reviewed-by: Kees Cook <keescook@chromium.org>
> ---
> I guess x86 can pick this up directly? Not sure where it should go
> exactly.
Ingo, can you snag this? (It's a more direct path, otherwise I can
take it via seccomp, which will go through my tree then James's
tree...)
-Kees
> ---
> samples/seccomp/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/samples/seccomp/Makefile b/samples/seccomp/Makefile
> index 4920903c8009..fb43a814d4c0 100644
> --- a/samples/seccomp/Makefile
> +++ b/samples/seccomp/Makefile
> @@ -34,6 +34,7 @@ HOSTCFLAGS_bpf-direct.o += $(MFLAG)
> HOSTCFLAGS_dropper.o += $(MFLAG)
> HOSTCFLAGS_bpf-helper.o += $(MFLAG)
> HOSTCFLAGS_bpf-fancy.o += $(MFLAG)
> +HOSTCFLAGS_user-trap.o += $(MFLAG)
> HOSTLDLIBS_bpf-direct += $(MFLAG)
> HOSTLDLIBS_bpf-fancy += $(MFLAG)
> HOSTLDLIBS_dropper += $(MFLAG)
> --
> 2.19.1
>
--
Kees Cook
next prev parent reply other threads:[~2019-01-07 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 23:16 [PATCH] samples/seccomp: fix 32-bit build Tycho Andersen
2019-01-07 23:18 ` Kees Cook [this message]
2019-01-08 6:43 ` Ingo Molnar
2019-01-08 6:48 ` [tip:x86/urgent] samples/seccomp: Fix " tip-bot for Tycho Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jK1pY-RqB_J5_obMDaWav8cJHjXQkpz0B4cHM=A8Ztq7w@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=tycho@tycho.ws \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).