From: Kees Cook <keescook@chromium.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
PowerPC <linuxppc-dev@lists.ozlabs.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Michael Bringmann <mwb@linux.vnet.ibm.com>
Subject: Re: linux-next: manual merge of the tip tree with the powerpc tree
Date: Wed, 1 Nov 2017 11:12:55 -0700 [thread overview]
Message-ID: <CAGXu5jKOOTsg4mAXRR3hHoeJ-RgvUhid9MQy=H0NL_KruHDbUg@mail.gmail.com> (raw)
In-Reply-To: <20171101165309.515688bc@canb.auug.org.au>
On Tue, Oct 31, 2017 at 10:53 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> Today's linux-next merge of the tip tree got a conflict in:
>
> arch/powerpc/mm/numa.c
>
> between commit:
>
> cee5405da402 ("powerpc/hotplug: Improve responsiveness of hotplug change")
>
> from the powerpc tree and commit:
>
> df7e828c1b69 ("timer: Remove init_timer_deferrable() in favor of timer_setup()")
>
> from the tip tree.
>
> I fixed it up (see below) and can carry the fix as necessary. This
> is now fixed as far as linux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
>
> --
> Cheers,
> Stephen Rothwell
>
> diff --cc arch/powerpc/mm/numa.c
> index eb604b3574fa,73016451f330..000000000000
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@@ -1506,9 -1466,7 +1505,7 @@@ static struct timer_list topology_timer
>
> static void reset_topology_timer(void)
> {
> - topology_timer.data = 0;
> - topology_timer.expires = jiffies + topology_timer_secs * HZ;
> - mod_timer(&topology_timer, topology_timer.expires);
> - mod_timer(&topology_timer, jiffies + 60 * HZ);
> ++ mod_timer(&topology_timer, jiffies + topology_timer_secs * HZ);
> }
>
> #ifdef CONFIG_SMP
> @@@ -1561,13 -1520,14 +1558,14 @@@ int start_topology_update(void
> rc = of_reconfig_notifier_register(&dt_update_nb);
> #endif
> }
> - } else if (firmware_has_feature(FW_FEATURE_VPHN) &&
> + }
> + if (firmware_has_feature(FW_FEATURE_VPHN) &&
> lppaca_shared_proc(get_lppaca())) {
> if (!vphn_enabled) {
> - prrn_enabled = 0;
> vphn_enabled = 1;
> setup_cpu_associativity_change_counters();
> - init_timer_deferrable(&topology_timer);
> + timer_setup(&topology_timer, topology_timer_fn,
> + TIMER_DEFERRABLE);
> reset_topology_timer();
> }
> }
Thanks, this looks correct to me!
-Kees
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2017-11-01 18:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-01 5:53 linux-next: manual merge of the tip tree with the powerpc tree Stephen Rothwell
2017-11-01 18:12 ` Kees Cook [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-15 2:08 Stephen Rothwell
2017-04-26 4:01 Stephen Rothwell
2017-02-17 1:48 Stephen Rothwell
2017-02-21 22:15 ` Stephen Rothwell
2012-03-09 4:40 Stephen Rothwell
2011-05-20 4:14 Stephen Rothwell
2011-05-20 5:38 ` Benjamin Herrenschmidt
2010-10-19 4:48 Stephen Rothwell
2010-10-19 4:56 ` Stephen Rothwell
2010-07-28 4:38 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jKOOTsg4mAXRR3hHoeJ-RgvUhid9MQy=H0NL_KruHDbUg@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=benh@kernel.crashing.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=mpe@ellerman.id.au \
--cc=mwb@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).