From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C190C10F14 for ; Thu, 18 Apr 2019 04:32:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC807217D7 for ; Thu, 18 Apr 2019 04:32:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="BwFdgFLF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726405AbfDREcd (ORCPT ); Thu, 18 Apr 2019 00:32:33 -0400 Received: from mail-ua1-f65.google.com ([209.85.222.65]:36120 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725710AbfDREcd (ORCPT ); Thu, 18 Apr 2019 00:32:33 -0400 Received: by mail-ua1-f65.google.com with SMTP id k32so358197uae.3 for ; Wed, 17 Apr 2019 21:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=emqG7/19kpW5wZ57vs/jCWwiZdoRZXGDohb1D974Avc=; b=BwFdgFLFNee7q4d/odil7gkB/UOuVM/QIlnvE7TGVcPxV0znLQ4z7fs87fH9FD/p2Q QIWn2YByOZWf2cz5EWUgLnTt8H1YHdlzqE3vWASVSstFIxPSA4Jhvnkwf4hkz5pNBDia 3hMlCG7M0QDEQlArREt5/8jUB1Ed/r+jW9qXM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=emqG7/19kpW5wZ57vs/jCWwiZdoRZXGDohb1D974Avc=; b=XJvA8v75pU1+NdCQjOMOr1JleGm6RoJuZfTXUbEzgrJkuEh5FVMahrx/6wfZ+qD2OT hYds1KUynVJNL/uNZSBn2QcS3s3FyiZgX2VLNNtxiblqEbHcSVmuVQq/p3qW7jV8xunv p+K2/IDGHZkDSsUIyiH1tc8VICr/Fq3L3K/cMnFbhqC1w04brc4b6n0Zealn/bY5Fe3X iTZXbekOMHhWk7wPYgOSIBsOrWlthoIecNHy9ROQ9kkhqDdPYX9Pp+HW02BNBVXsOW0v oeMhthbiPktO2rNIIi4OwydYnRp12WoE1X2piGCKIVK/1YMNPTsMiBl2eyQJyXiufXOA UmCA== X-Gm-Message-State: APjAAAVgcD720ygQOHqMzYSQfMSyPinbAgjFcq7bJHRJQkJgXD/f4lhj iJemII2GPq0AaJMseNbwW4CSBGe1edc= X-Google-Smtp-Source: APXvYqxDscnBD8IAdqG/V1NGtPqaa1IFiRwN924LPW+7w3DO/I9ZbmMc17WlPAKZ6UlH4ANh436kTA== X-Received: by 2002:ab0:4eaa:: with SMTP id l42mr45061730uah.80.1555561951726; Wed, 17 Apr 2019 21:32:31 -0700 (PDT) Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com. [209.85.217.44]) by smtp.gmail.com with ESMTPSA id b81sm292672vkf.47.2019.04.17.21.32.29 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 17 Apr 2019 21:32:30 -0700 (PDT) Received: by mail-vs1-f44.google.com with SMTP id e2so432103vsc.13 for ; Wed, 17 Apr 2019 21:32:29 -0700 (PDT) X-Received: by 2002:a67:bc13:: with SMTP id t19mr2517845vsn.222.1555561949440; Wed, 17 Apr 2019 21:32:29 -0700 (PDT) MIME-Version: 1.0 References: <20190417052247.17809-1-alex@ghiti.fr> <20190417052247.17809-3-alex@ghiti.fr> In-Reply-To: <20190417052247.17809-3-alex@ghiti.fr> From: Kees Cook Date: Wed, 17 Apr 2019 23:32:17 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 02/11] arm64: Make use of is_compat_task instead of hardcoding this test To: Alexandre Ghiti Cc: Andrew Morton , Christoph Hellwig , Russell King , Catalin Marinas , Will Deacon , Ralf Baechle , Paul Burton , James Hogan , Palmer Dabbelt , Albert Ou , Alexander Viro , Luis Chamberlain , Kees Cook , LKML , linux-arm-kernel , linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, "linux-fsdevel@vger.kernel.org" , Linux-MM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 17, 2019 at 12:25 AM Alexandre Ghiti wrote: > > Each architecture has its own way to determine if a task is a compat task, > by using is_compat_task in arch_mmap_rnd, it allows more genericity and > then it prepares its moving to mm/. > > Signed-off-by: Alexandre Ghiti Acked-by: Kees Cook -Kees > --- > arch/arm64/mm/mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c > index 842c8a5fcd53..ed4f9915f2b8 100644 > --- a/arch/arm64/mm/mmap.c > +++ b/arch/arm64/mm/mmap.c > @@ -54,7 +54,7 @@ unsigned long arch_mmap_rnd(void) > unsigned long rnd; > > #ifdef CONFIG_COMPAT > - if (test_thread_flag(TIF_32BIT)) > + if (is_compat_task()) > rnd = get_random_long() & ((1UL << mmap_rnd_compat_bits) - 1); > else > #endif > -- > 2.20.1 > -- Kees Cook