From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B8A7ECDE5F for ; Thu, 19 Jul 2018 18:44:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D21442084C for ; Thu, 19 Jul 2018 18:44:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="aQ7zS5BG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="d+Y/sJeH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D21442084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732819AbeGST2a (ORCPT ); Thu, 19 Jul 2018 15:28:30 -0400 Received: from mail-yw0-f195.google.com ([209.85.161.195]:43185 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732058AbeGST2a (ORCPT ); Thu, 19 Jul 2018 15:28:30 -0400 Received: by mail-yw0-f195.google.com with SMTP id l189-v6so3444320ywb.10 for ; Thu, 19 Jul 2018 11:44:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Vf1Cj2gWY6Lc94sum+D9LGaxI+58ZuzLm0TYnndNKtE=; b=aQ7zS5BGJVKo6zX8FXWVGyRb+KezKHmfVpVJerFZq5VgEvMecy/SBq8ttLV0wU88of 7U+QFlrSn9H96LjHq/zW4oi5m+4prdOn2yGq679qtIrfuC6wng+9tjVCVrqTrDOR4NfJ sFhAeon8EKgCsay0Z1ych43IsAfaz2XhHiGajnkZA08MceA0gx4qQ4B78a6TAVYB4YE7 RCl7nrCLg5diverFYFwFXUjJaV90g47LRK69HKBWJ990DrmSnsV7wm4muf67+l9WiSXw KQBRHQ/4UGM3MXvRVkbNCMY1KDe13Iye3xdKhT03zntxF/iyKjLVZNKFG/g1ibB9cds4 Wzww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Vf1Cj2gWY6Lc94sum+D9LGaxI+58ZuzLm0TYnndNKtE=; b=d+Y/sJeHkZgNkPg+nMDr2aoXpkehbZ9rAhmYJi5vCZ/yjkf41RTJrxhcEA4qAKt29M 1Nk0tqAkHGw7mpzY635oMvDFq7C0MPThDRvF2/pfttLf6h3rWHAgfHnmJrRUWCKxU88a S+eydiyzvG10pp/d9IQ1AfqJUkCF93uoOZlAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Vf1Cj2gWY6Lc94sum+D9LGaxI+58ZuzLm0TYnndNKtE=; b=bnShZqqRPHPUCIDxV+8uNSeUeQU7cMDWAQs5fq8xch1jP/Enxd2e0KtUHQwpvXAEqf T3Vnwj8xYxKWsOUgdTRkO8ywQTHQxK4txW7AGGAdfIkC6+nzWvrkWzKA2e353U+qEJa0 okiKZ3wk+vgSzZ9mKpf3WXi8ldRuV5i8tUvJK0Az7RXZ/BzGNAROIcNxOP1wW3bdAdD8 khTPvV3hKOQxzsBU8z845exWLUNNSHEx9KTlSIpkLQAzsk8QDiloUaHjIpwTCNyhn5d2 FvBTQROAKahvcvVvuujS8+uu9G0W9NkUxMIh3/jc0nwGAXd9xKdronFB6q0kKOxEhNa6 9D2Q== X-Gm-Message-State: AOUpUlEnfCSIHU3P9fx+oGD8NwUcgcwGQluAAIg4HzbA7xWM31ATn6Bh Sm/WfIgcGN7G+fpiVqDSqRS6RfW8CMGJPxRnOzMTFQ== X-Google-Smtp-Source: AAOMgpe8HNF636+QIjbludJenYQ9E87/1XvxnMwRDcUjMljVjqYS/vguNFth7UwMIYDy+EZ1A+cKdH6hlELhLodoM0U= X-Received: by 2002:a0d:f002:: with SMTP id z2-v6mr6111054ywe.116.1532025844683; Thu, 19 Jul 2018 11:44:04 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:6602:0:0:0:0:0 with HTTP; Thu, 19 Jul 2018 11:44:03 -0700 (PDT) In-Reply-To: References: <20180711203619.1020-1-keescook@chromium.org> <20180711203619.1020-12-keescook@chromium.org> <20180713004038.lwibdesz7ohhoind@gondor.apana.org.au> <20180713034406.zwu2pkp3f2onybxs@gondor.apana.org.au> <20180713052029.cfo24bsr5swtbdja@gondor.apana.org.au> From: Kees Cook Date: Thu, 19 Jul 2018 11:44:03 -0700 X-Google-Sender-Auth: Y8QqvoaKzlaZemsV2C2gr_XJvlw Message-ID: Subject: Re: [PATCH v4 11/14] treewide: Prepare to remove VLA usage for AHASH_REQUEST_ON_STACK To: Ard Biesheuvel Cc: Arnd Bergmann , Herbert Xu , "Gustavo A. R. Silva" , Eric Biggers , Alasdair Kergon , Giovanni Cabiddu , Lars Persson , Mike Snitzer , Rabin Vincent , Tim Chen , "David S. Miller" , Masahiro Yamada , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , qat-linux@intel.com, dm-devel@redhat.com, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 19, 2018 at 7:54 AM, Ard Biesheuvel wrote: > On 19 July 2018 at 12:13, Ard Biesheuvel wrote: >> >>> On 19 Jul 2018, at 12:09, Kees Cook wrote: >>> >>> On Wed, Jul 18, 2018 at 7:55 PM, Ard Biesheuvel >>> wrote: >>>> I have only build tested it, so if you make sure that it does not break anything, please go ahead. >>> >>> I can give it a spin; what's the best way? Is CONFIG_CRYPTO_MANAGER=y >>> sufficient? >>> >> >> You should be able to test ccm(aes) with tcrypt, yes > > Apologies, I should have been more clear here. I was replying on my > phone while attending a meeting. > > The builtin test will only kick in for chaining mode templates if they > are instantiated by something that invokes the algorithm, such as > loading tcrypt.ko with mode=37 (assuming that ccm(aes) has to be > instantiated from crypto/ccm.c and some AES cipher rather than being > provided directly by, e.g., arm64's AES-CCM driver) > > I just did the tcrypt myself, and the patch appears to be fine. Let me > know if you want me to spin the patch. Awesome, thanks for testing! I built a commit with you as the author. I'll send it out with the next batch... :) -Kees -- Kees Cook Pixel Security