From: Kees Cook <keescook@chromium.org>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: David Airlie <airlied@linux.ie>,
Gerd Hoffmann <kraxel@redhat.com>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/ttm: use designated initializers
Date: Tue, 20 Dec 2016 11:55:38 -0800 [thread overview]
Message-ID: <CAGXu5jKdVnho0vEgLHOCCoQZAKu4fm600ZzuSSyyiDLsuvgc2A@mail.gmail.com> (raw)
In-Reply-To: <20161217005929.GA140260@beast>
On Sun, Dec 18, 2016 at 10:53 PM, Alexander Stein
<alexander.stein@systec-electronic.com> wrote:
> Hello Kees,
>
> While understanding what your patches (I've seen the other ones as well) do
> themself, I still don't get what your intention is, e.g. why you need this?
> Apart from a better readability.
>
> On Friday 16 December 2016 16:59:29, Kees Cook wrote:
>> Prepare to mark sensitive kernel structures for randomization by making
>> sure they're using designated initializers.
>
> Can you please elaborate what you mean with that sentence?
Hi! Sure: the coming (and optional) gcc plugin "randstruct" performs
structure layout randomization, which means that static initializers
cannot be "ordered" (they must be "designated"), since the place were
layout randomization occurs happens separate from how static
initializers are applied.
This change from ordered to designated is just to help the compiler do
the right thing.
-Kees
--
Kees Cook
Nexus Security
next prev parent reply other threads:[~2016-12-20 19:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 0:59 [PATCH] drm/ttm: use designated initializers Kees Cook
2016-12-20 19:55 ` Kees Cook [this message]
2016-12-17 1:00 Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jKdVnho0vEgLHOCCoQZAKu4fm600ZzuSSyyiDLsuvgc2A@mail.gmail.com \
--to=keescook@chromium.org \
--cc=airlied@linux.ie \
--cc=alexander.stein@systec-electronic.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).