From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1750869AbdE0UKr (ORCPT <rfc822;w@1wt.eu>);
        Sat, 27 May 2017 16:10:47 -0400
Received: from mail-io0-f176.google.com ([209.85.223.176]:33762 "EHLO
        mail-io0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750737AbdE0UKq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 27 May 2017 16:10:46 -0400
MIME-Version: 1.0
In-Reply-To: <20170527084748.GA11558@infradead.org>
References: <1495829844-69341-1-git-send-email-keescook@chromium.org>
 <1495829844-69341-15-git-send-email-keescook@chromium.org> <20170527084748.GA11558@infradead.org>
From: Kees Cook <keescook@chromium.org>
Date: Sat, 27 May 2017 13:10:44 -0700
X-Google-Sender-Auth: UC3LPUY4OCQM7pKO7-t-KaDosqc
Message-ID: <CAGXu5jKiMDQGBZbea0=Pz03G=8SSUvsTrQq=sMQLwWZ_SMrRxg@mail.gmail.com>
Subject: Re: [PATCH v2 14/20] drm/amd/powerplay: Use designated initializers
To: Christoph Hellwig <hch@infradead.org>
Cc: "kernel-hardening@lists.openwall.com" 
        <kernel-hardening@lists.openwall.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        Eric Huang <JinHuiEric.Huang@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Laura Abbott <labbott@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 27, 2017 at 1:47 AM, Christoph Hellwig <hch@infradead.org> wrote:
>> +     { .isFunctionNeededInRuntimeTable = NULL,
>> +       .tableFunction = tf_vega10_thermal_initialize },
>
> I'd say drop the NULL initializations as they are implicit anyway.

Oh, dur, yeah, I'll improve this.

-Kees

-- 
Kees Cook
Pixel Security