From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966025AbcKKAKq (ORCPT <rfc822;w@1wt.eu>);
        Thu, 10 Nov 2016 19:10:46 -0500
Received: from mail-wm0-f45.google.com ([74.125.82.45]:36441 "EHLO
        mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S935019AbcKKAKp (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 10 Nov 2016 19:10:45 -0500
MIME-Version: 1.0
In-Reply-To: <1476948846-15006-4-git-send-email-joelaf@google.com>
References: <1476948846-15006-1-git-send-email-joelaf@google.com> <1476948846-15006-4-git-send-email-joelaf@google.com>
From: Kees Cook <keescook@chromium.org>
Date: Thu, 10 Nov 2016 16:10:43 -0800
X-Google-Sender-Auth: xSL3MR5qekrmKbKBwoN7N04W4eU
Message-ID: <CAGXu5jKt0E8_=bOATNeDQNNvAPCidzQ91ESO=cTwVkNL3Acz7A@mail.gmail.com>
Subject: Re: [PATCH v2 3/7] pstore: Warn for the case of PSTORE_TYPE_PMSG
 write using deprecated function
To: Joel Fernandes <joelaf@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Anton Vorontsov <anton@enomsg.org>, Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 20, 2016 at 12:34 AM, Joel Fernandes <joelaf@google.com> wrote:
> PMSG now uses ramoops_pstore_write_buf_user instead of ramoops_pstore_write_buf
> Print a ratelimited warning if the ramoops_pstore_write_buf is called.
>
> Signed-off-by: Joel Fernandes <joelaf@google.com>
> ---
>  fs/pstore/ram.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
> index cb07ef6..9104ae9 100644
> --- a/fs/pstore/ram.c
> +++ b/fs/pstore/ram.c
> @@ -288,10 +288,8 @@ static int notrace ramoops_pstore_write_buf(enum pstore_type_id type,
>                 persistent_ram_write(cxt->fprz, buf, size, PSTORE_RAM_LOCK);
>                 return 0;
>         } else if (type == PSTORE_TYPE_PMSG) {
> -               if (!cxt->mprz)
> -                       return -ENOMEM;
> -               persistent_ram_write(cxt->mprz, buf, size, PSTORE_RAM_LOCK);
> -               return 0;
> +               pr_warn_ratelimited("ramoops: warning: PMSG shouldn't call %s\n",
> +                                   __func__);
>         }
>
>         if (type != PSTORE_TYPE_DMESG)
> --
> 2.7.4
>

Cool, I'll take this into -next too since it's stand-alone.

Thanks!

-Kees

-- 
Kees Cook
Nexus Security