From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751209AbdEBXQI (ORCPT ); Tue, 2 May 2017 19:16:08 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:36473 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbdEBXQG (ORCPT ); Tue, 2 May 2017 19:16:06 -0400 MIME-Version: 1.0 In-Reply-To: <20170502222641.7142-1-mic@digikod.net> References: <20170502222641.7142-1-mic@digikod.net> From: Kees Cook Date: Tue, 2 May 2017 16:16:05 -0700 X-Google-Sender-Auth: 4l-Eosh1rpx7EPUouxwjyJajrVI Message-ID: Subject: Re: [PATCH v2 0/6] Add kselftest_harness.h To: =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= Cc: LKML , Andy Lutomirski , Jonathan Corbet , Shuah Khan , Will Drewry , "linux-doc@vger.kernel.org" , linux-kselftest@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v42NGLsA006815 On Tue, May 2, 2017 at 3:26 PM, Mickaël Salaün wrote: > Hi, > > This second patch series make the seccomp/test_harness.h more generally > available [1] and update the kselftest documentation with the Sphinx format. It > also improve the Makefile of seccomp tests to take into account any > kselftest_harness.h update. > > [1] https://lkml.kernel.org/r/CAGXu5j+8CVz8vL51DRYXqOY=xc3zuKFf=PTENe88XYHzFYidUQ@mail.gmail.com > > Regards, > > Mickaël Salaün (6): > selftests: Make test_harness.h more generally available > selftests: Cosmetic renames in kselftest_harness.h > selftests/seccomp: Force rebuild according to dependencies > Documentation/dev-tools: Add kselftest For these four: Acked-by: Kees Cook > Documentation/dev-tools: Use reStructuredText markups for kselftest > Documentation/dev-tools: Add kselftest_harness documentation These two have some minor nits I emailed about, but if those are fixed, consider them Acked-by me too. Thanks for this! -Kees > > Documentation/00-INDEX | 2 - > Documentation/dev-tools/index.rst | 1 + > .../{kselftest.txt => dev-tools/kselftest.rst} | 134 +++++++++-- > MAINTAINERS | 1 + > .../test_harness.h => kselftest_harness.h} | 268 +++++++++++++++------ > tools/testing/selftests/seccomp/Makefile | 2 + > tools/testing/selftests/seccomp/seccomp_bpf.c | 2 +- > 7 files changed, 307 insertions(+), 103 deletions(-) > rename Documentation/{kselftest.txt => dev-tools/kselftest.rst} (52%) > rename tools/testing/selftests/{seccomp/test_harness.h => kselftest_harness.h} (81%) > > -- > 2.11.0 > -- Kees Cook Pixel Security