From: Kees Cook <keescook@chromium.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, James Morris <jmorris@namei.org>
Subject: Re: [PATCH v1] lib/string_helpers: Add missed declaration of struct task_struct
Date: Thu, 10 May 2018 13:59:46 -0700 [thread overview]
Message-ID: <CAGXu5jL64DfHcg_ncdi6AxF+zF=bQePU6Cqt3i3qks4dN36=yQ@mail.gmail.com> (raw)
In-Reply-To: <CAGXu5j+p=ngqY_3oqMn83YMjjomKeQSs3Akk7+YfY5sPmcxw+g@mail.gmail.com>
On Thu, May 3, 2018 at 9:34 PM, Kees Cook <keescook@chromium.org> wrote:
> On Thu, May 3, 2018 at 6:13 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
>> Starting from the commit 0d0443288f22 the new function has been
>> introduced which takes struct task_struct as a parameter. Though,
>> compiler doesn't know where to get information about it at this stage.
>>
>> Add missed declaration of struct task_struct to satisfy compiler.
>>
>> Fixes: 0d0443288f22 ("string_helpers: add kstrdup_quotable_cmdline")
>> Cc: Kees Cook <keescook@chromium.org>
>> Cc: James Morris <james.l.morris@oracle.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> I'm not sure who should carry this. You're welcome to put it in your tree?
I haven't seen this show up in linux-next. Andy will you be taking it?
-Kees
>
> -Kees
>
>> ---
>> include/linux/string_helpers.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/string_helpers.h b/include/linux/string_helpers.h
>> index 4397c52ec4a4..d23c5030901a 100644
>> --- a/include/linux/string_helpers.h
>> +++ b/include/linux/string_helpers.h
>> @@ -5,6 +5,7 @@
>> #include <linux/types.h>
>>
>> struct file;
>> +struct task_struct;
>>
>> /* Descriptions of the types of units to
>> * print in */
>> --
>> 2.17.0
>>
>
>
>
> --
> Kees Cook
> Pixel Security
--
Kees Cook
Pixel Security
next prev parent reply other threads:[~2018-05-10 20:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 1:13 [PATCH v1] lib/string_helpers: Add missed declaration of struct task_struct Andy Shevchenko
2018-05-04 4:34 ` Kees Cook
2018-05-10 20:59 ` Kees Cook [this message]
2018-05-15 18:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jL64DfHcg_ncdi6AxF+zF=bQePU6Cqt3i3qks4dN36=yQ@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).