From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753485AbcGYSyJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jul 2016 14:54:09 -0400
Received: from mail-wm0-f41.google.com ([74.125.82.41]:37317 "EHLO
	mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752933AbcGYSyG (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jul 2016 14:54:06 -0400
MIME-Version: 1.0
In-Reply-To: <1469471141-25669-1-git-send-email-william.c.roberts@intel.com>
References: <1469471141-25669-1-git-send-email-william.c.roberts@intel.com>
From: Kees Cook <keescook@chromium.org>
Date: Mon, 25 Jul 2016 11:54:02 -0700
X-Google-Sender-Auth: rDGLR1UHvw4YRsLYGl5I5L4u1Cw
Message-ID: <CAGXu5jLOk52XzQT9EA8vq5B3G3ks8Nmsfc6keA8kpG9LvaTE9Q@mail.gmail.com>
Subject: Re: [PATCH] randomize_range: use random long instead of int
To: "Roberts, William C" <william.c.roberts@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        Russell King - ARM Linux <linux@arm.linux.org.uk>,
        "Theodore Ts'o" <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
        Greg KH <gregkh@linuxfoundation.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Ralf Baechle <ralf@linux-mips.org>,
        "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        "David S. Miller" <davem@davemloft.net>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, "x86@kernel.org" <x86@kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>, Nick Kralevich <nnk@google.com>,
        Jeffrey Vander Stoep <jeffv@google.com>,
        Mark Salyzyn <salyzyn@android.com>,
        Daniel Cashman <dcashman@android.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 25, 2016 at 11:25 AM,  <william.c.roberts@intel.com> wrote:
> From: William Roberts <william.c.roberts@intel.com>
>
> Use a long when generating the random range rather than
> an int. This will produce better random distributions as
> well as matching all the types at hand.
>
> Signed-off-by: William Roberts <william.c.roberts@intel.com>

I agree, this is what I pointed out back in Feb:
https://lkml.org/lkml/2016/2/4/854

Acked-by: Kees Cook <keescook@chromium.org>

Andrew, can you pick this up for 4.8?

-Kees

> ---
>  drivers/char/random.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/char/random.c b/drivers/char/random.c
> index 0158d3b..bbf11b5 100644
> --- a/drivers/char/random.c
> +++ b/drivers/char/random.c
> @@ -1837,7 +1837,8 @@ randomize_range(unsigned long start, unsigned long end, unsigned long len)
>
>         if (end <= start + len)
>                 return 0;
> -       return PAGE_ALIGN(get_random_int() % range + start);
> +
> +       return PAGE_ALIGN(get_random_long() % range + start);
>  }
>
>  /* Interface for in-kernel drivers of true hardware RNGs.
> --
> 1.9.1
>



-- 
Kees Cook
Chrome OS & Brillo Security