From: Kees Cook <keescook@chromium.org>
To: Sinan Kaya <okaya@kernel.org>, Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH v5 0/5] init: Do not select DEBUG_KERNEL by default
Date: Sun, 14 Apr 2019 20:55:55 -0700 [thread overview]
Message-ID: <CAGXu5jLRnq1WeDtMSwE_qnve_O9+GiZd4m=N=_1rBidwRwmeJg@mail.gmail.com> (raw)
In-Reply-To: <20190413224438.10802-1-okaya@kernel.org>
On Sat, Apr 13, 2019 at 3:44 PM Sinan Kaya <okaya@kernel.org> wrote:
>
> CONFIG_DEBUG_KERNEL has been designed to just enable Kconfig options.
> Kernel code generatoin should not depend on CONFIG_DEBUG_KERNEL.
>
> Proposed alternative plan: let's add a new symbol, something like
> DEBUG_MISC ("Miscellaneous debug code that should be under a more
> specific debug option but isn't"), make it depend on DEBUG_KERNEL and be
> "default DEBUG_KERNEL" but allow itself to be turned off, and then
> mechanically change the small handful of "#ifdef CONFIG_DEBUG_KERNEL" to
> "#ifdef CONFIG_DEBUG_MISC".
Thanks! This looks good to me. For the series:
Reviewed-by: Kees Cook <keescook@chromium.org>
Andrew, can you take these from lkml, or should the series get resent
directly to you? I think you might be the best to carry this?
Thanks!
-Kees
>
> Diff from v4:
> - collect reviewed-by
> - collect acked-by
> - fix nit on 1/5
>
> Sinan Kaya (5):
> init: Introduce DEBUG_MISC option
> powerpc: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
> mips: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
> xtensa: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
> net: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC
>
> arch/mips/kernel/setup.c | 2 +-
> arch/powerpc/kernel/sysfs.c | 8 ++++----
> arch/xtensa/include/asm/irqflags.h | 2 +-
> arch/xtensa/kernel/smp.c | 2 +-
> lib/Kconfig.debug | 9 +++++++++
> net/netfilter/core.c | 2 +-
> 6 files changed, 17 insertions(+), 8 deletions(-)
>
> --
> 2.21.0
>
--
Kees Cook
next prev parent reply other threads:[~2019-04-15 3:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 22:44 [PATCH v5 0/5] init: Do not select DEBUG_KERNEL by default Sinan Kaya
2019-04-13 22:44 ` [PATCH v5 1/5] init: Introduce DEBUG_MISC option Sinan Kaya
2019-04-13 22:44 ` [PATCH v5 2/5] powerpc: Replace CONFIG_DEBUG_KERNEL with CONFIG_DEBUG_MISC Sinan Kaya
2019-04-13 22:44 ` [PATCH v5 3/5] mips: " Sinan Kaya
2019-04-13 22:44 ` [PATCH v5 4/5] xtensa: " Sinan Kaya
2019-04-13 22:48 ` Max Filippov
2019-04-13 22:44 ` [PATCH v5 5/5] net: " Sinan Kaya
2019-04-15 3:55 ` Kees Cook [this message]
2019-04-23 22:02 ` [PATCH v5 0/5] init: Do not select DEBUG_KERNEL by default Sinan Kaya
2019-04-23 22:05 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jLRnq1WeDtMSwE_qnve_O9+GiZd4m=N=_1rBidwRwmeJg@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).