From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756616AbcBXXh4 (ORCPT ); Wed, 24 Feb 2016 18:37:56 -0500 Received: from mail-ig0-f177.google.com ([209.85.213.177]:36100 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbcBXXhy (ORCPT ); Wed, 24 Feb 2016 18:37:54 -0500 MIME-Version: 1.0 In-Reply-To: References: <1455844533-24787-1-git-send-email-labbott@fedoraproject.org> <56C79301.5040003@redhat.com> <56C7A02F.7070902@redhat.com> <56CB866A.8070306@redhat.com> <56CE072F.7060804@redhat.com> Date: Wed, 24 Feb 2016 15:37:53 -0800 X-Google-Sender-Auth: dSktl5mXpnqu9TyYyHzvDzksUn0 Message-ID: Subject: Re: [PATCHv2] lkdtm: Add READ_AFTER_FREE test From: Kees Cook To: Laura Abbott Cc: Laura Abbott , Greg Kroah-Hartman , Arnd Bergmann , "kernel-hardening@lists.openwall.com" , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 24, 2016 at 1:48 PM, Kees Cook wrote: > On Wed, Feb 24, 2016 at 11:40 AM, Laura Abbott wrote: >> Yep, looks like the v1 patches and not the v2 patches which fix >> a known issue with the zeroing. > > Ah-ha, I'll go find those and retest. I sent out a series that was rebased. It works for me, but I want to make sure I didn't make any glaring issues. I've also sent some fixes to the lkdtm tests. One thing that stands out to me still is that the READ_AFTER_FREE never shows poisoning. I remain confused, since obviously if zeroing is working, it's being correctly poisoned... -Kees -- Kees Cook Chrome OS & Brillo Security