From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751319AbdH2AKh (ORCPT ); Mon, 28 Aug 2017 20:10:37 -0400 Received: from mail-io0-f174.google.com ([209.85.223.174]:38495 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbdH2AKf (ORCPT ); Mon, 28 Aug 2017 20:10:35 -0400 X-Google-Smtp-Source: ADKCNb5D7NW2gkZIzyM5LKi4mdEgzSliRquCcXHqPQxZlD3siq8+VYjLNeDKZkhDpAQ7DTGPzxf4d6J4Gh8RE3HWF5A= MIME-Version: 1.0 In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F61349912@ORSMSX114.amr.corp.intel.com> References: <20170817213946.16939-1-tony.luck@intel.com> <20170818013047.427e38b7@alans-desktop> <3908561D78D1C84285E8C5FCA982C28F61349912@ORSMSX114.amr.corp.intel.com> From: Kees Cook Date: Mon, 28 Aug 2017 17:10:33 -0700 Message-ID: Subject: Re: [PATCH] ACPI / sysfs: Extend ACPI sysfs to provide access to boot error region To: "Luck, Tony" Cc: Alan Cox , "Rafael J. Wysocki" , Len Brown , Boris Petkov , Tyler Baicar , Punit Agrawal , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 23, 2017 at 7:56 AM, Luck, Tony wrote: >>> Should this not also have a capability check. Assuming file permissions >>> are sufficient for grabbing a chunk of system memory holding error >>> info doesn't seem too scary but it's at odds with a lot of other cases ? >> >> At least one of those other cases (pstore) added a capability check and now regret >> it. There's a thread on reverting it. Look for: >> >> Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" > > Here's at least part of that thread: > > https://marc.info/?l=linux-kernel&m=150301241114262&w=2 > > Kees: you were OK with removing the capability check from pstore, right? Yeah, as long as there is comparable protections. -Kees -- Kees Cook Pixel Security