From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: ARC-Seal: i=1; a=rsa-sha256; t=1522256109; cv=none; d=google.com; s=arc-20160816; b=e6KGs8KlVNJQOF8w+I8v4o+PHLOMRXQNbj+Qg9d9TItC9vdGC1/geFiZWSjUEM8qQ6 TV5KfJyDV0N+xpNkqfgkAM5yc+HF7f9DL9Nrz8LS4RAS9Tz8bGT2EmgJnrZyJH8377S2 FnKFUsMYxVHezSuFWRfpMXBlOhVKTUX8ugZKqSjRoLyTT7J2bFuXEnE2Qeo2AUy2Hhmi QwUDkxrT8FpECNX/TxtadUong0Ya/xUJHqJOMKxRhigoeijizjnU//kJIniD855hKzhU +sT57SkLvllZUM23CwTcei5cp9TVCSBU50uXr4gTxe6Io3PjaoG67Hv4re1PPcG2AneF amRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:references:in-reply-to:sender :mime-version:dkim-signature:dkim-signature :arc-authentication-results; bh=igUoMncjJWqGkLK9YYc5OMgjbea66b9N6X1DVXnuShw=; b=SqP+cRFHV4jLN+2DqkBUerstpc/oFU4LVObhJrJOet7PlGJPAiyumsT+zXabZBvzre cRlszX0ykz03Koj6h5zWaNiGi+9o89FwKwDzeRC3RVG+drIRvvC3AfjvKJp1QbJkgzgu jEKoGPX67FqHhsJtOJYHHWSK4HP2ka2RCIegGKWUrHAaLDSg7sy6AAcxcKEF9UvoYnQ9 XqpuYRVMoR//n2J5DpG76IU15JJSpcRBaUC+xryUs49BRTrZ5xcL+FvCook3LASDwR3D dbpH9FPMMFizgUrsQukFjH0o3lboY/ikzGiXtahwep7btUTc4l/GY1zJ/NFTAfkGa9jE cMBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Lx1Vfi6y; dkim=pass header.i=@chromium.org header.s=google header.b=C9F023bT; spf=pass (google.com: domain of keescook@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=keescook@google.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=Lx1Vfi6y; dkim=pass header.i=@chromium.org header.s=google header.b=C9F023bT; spf=pass (google.com: domain of keescook@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=keescook@google.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org X-Google-Smtp-Source: AIpwx4/AaLNWnGImizTYImMY7WTQ/KVrr96pT4C3C5y6iI+e3+5ICgEO9lC7H7JLJZic5Jr9QqExXYJ9ZLR+fu29qKM= MIME-Version: 1.0 Sender: keescook@google.com In-Reply-To: <20180328152714.6103-1-shea@shealevy.com> References: <20180325221853.10839-1-shea@shealevy.com> <20180328152714.6103-1-shea@shealevy.com> From: Kees Cook Date: Wed, 28 Mar 2018 09:55:07 -0700 X-Google-Sender-Auth: pJbrkNlGYsOjm2QGq3dxmEwoNP4 Message-ID: Subject: Re: [PATCH] Extract initrd free logic from arch-specific code. To: Shea Levy Cc: linux-riscv@lists.infradead.org, LKML , Christoph Hellwig , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Mark Salter , Aurelien Jacquiot , Mikael Starvik , Jesper Nilsson , Yoshinori Sato , Richard Kuo , Tony Luck , Fenghua Yu , Geert Uytterhoeven , James Hogan , Michal Simek , Ralf Baechle , David Howells , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Palmer Dabbelt , Albert Ou , Martin Schwidefsky , Heiko Carstens , Chen Liqin , Lennox Wu , Rich Felker , "David S. Miller" , Jeff Dike , Richard Weinberger , Guan Xuetao , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , X86 ML , Chris Zankel , Max Filippov , Kate Stewart , Greg Kroah-Hartman , Philippe Ombredanne , Eugeniy Paltsev , Al Viro , Vladimir Murzin , Linus Walleij , Michal Hocko , Andrew Morton , Sudip Mukherjee , Marc Zyngier , Rob Herring , Vlastimil Babka , Balbir Singh , Christophe Leroy , Joe Perches , "Oliver O'Halloran" , Dan Williams , Wei Yang , =?UTF-8?Q?Christian_K=C3=B6nig?= , Arnd Bergmann , Deepa Dinamani , Daniel Thompson , Rob Landley , Florian Fainelli , linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel , adi-buildroot-devel@lists.sourceforge.net, linux-c6x-dev@linux-c6x.org, linux-cris-kernel@axis.com, uclinux-h8-devel@lists.sourceforge.jp, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-metag@vger.kernel.org, Linux MIPS Mailing List , linux-am33-list@redhat.com, nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, linux-parisc , PowerPC , linux-s390 , linux-sh , sparclinux , user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, linux-xtensa@linux-xtensa.org Content-Type: text/plain; charset="UTF-8" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1596195734883590774?= X-GMAIL-MSGID: =?utf-8?q?1596201222621078100?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Mar 28, 2018 at 8:26 AM, Shea Levy wrote: > Now only those architectures that have custom initrd free requirements > need to define free_initrd_mem. > > Signed-off-by: Shea Levy Yay consolidation! :) > --- a/usr/Kconfig > +++ b/usr/Kconfig > @@ -233,3 +233,7 @@ config INITRAMFS_COMPRESSION > default ".lzma" if RD_LZMA > default ".bz2" if RD_BZIP2 > default "" > + > +config HAVE_ARCH_FREE_INITRD_MEM > + bool > + default n If you keep the Kconfig, you can leave off "default n", and I'd suggest adding a help section just to describe what the per-arch responsibilities are when select-ing the config. (See HAVE_ARCH_SECCOMP_FILTER for an example.) -Kees -- Kees Cook Pixel Security