From: Kees Cook <keescook@chromium.org>
To: "Mickaël Salaün" <mic@digikod.net>, "James Morris" <jmorris@namei.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
"Luis R . Rodriguez" <mcgrof@kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"# 3.4.x" <stable@vger.kernel.org>,
linux-security-module <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook
Date: Mon, 11 Jul 2016 14:41:57 -0400 [thread overview]
Message-ID: <CAGXu5jLmB-0FzZaxqetnAZEYj0MGKkgADue44gWmydwkfpq6xg@mail.gmail.com> (raw)
In-Reply-To: <1468088355-18484-1-git-send-email-mic@digikod.net>
On Sat, Jul 9, 2016 at 2:19 PM, Mickaël Salaün <mic@digikod.net> wrote:
> Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel version")
Oh, hrm, was that still in there? Thanks for the catch!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> include/linux/lsm_hooks.h | 1 -
> include/linux/security.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index 7ae397669d8b..58c777ec8bcf 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -1455,7 +1455,6 @@ union security_list_options {
> int (*kernel_act_as)(struct cred *new, u32 secid);
> int (*kernel_create_files_as)(struct cred *new, struct inode *inode);
> int (*kernel_module_request)(char *kmod_name);
> - int (*kernel_module_from_file)(struct file *file);
> int (*kernel_read_file)(struct file *file, enum kernel_read_file_id id);
> int (*kernel_post_read_file)(struct file *file, char *buf, loff_t size,
> enum kernel_read_file_id id);
> diff --git a/include/linux/security.h b/include/linux/security.h
> index 14df373ff2ca..2b8c7d2a3fd8 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -307,7 +307,6 @@ void security_transfer_creds(struct cred *new, const struct cred *old);
> int security_kernel_act_as(struct cred *new, u32 secid);
> int security_kernel_create_files_as(struct cred *new, struct inode *inode);
> int security_kernel_module_request(char *kmod_name);
> -int security_kernel_module_from_file(struct file *file);
> int security_kernel_read_file(struct file *file, enum kernel_read_file_id id);
> int security_kernel_post_read_file(struct file *file, char *buf, loff_t size,
> enum kernel_read_file_id id);
> --
> 2.8.1
>
--
Kees Cook
Chrome OS & Brillo Security
next prev parent reply other threads:[~2016-07-11 18:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 18:19 [PATCH v1] module: Fully remove the kernel_module_from_file hook Mickaël Salaün
2016-07-11 18:41 ` Kees Cook [this message]
2016-07-11 21:42 ` Greg Kroah-Hartman
2016-07-12 12:48 ` James Morris
2016-07-28 18:30 ` Kees Cook
2016-08-01 2:34 ` Mimi Zohar
2016-08-02 1:12 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXu5jLmB-0FzZaxqetnAZEYj0MGKkgADue44gWmydwkfpq6xg@mail.gmail.com \
--to=keescook@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mic@digikod.net \
--cc=rusty@rustcorp.com.au \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).