From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B127C433EF for ; Tue, 10 May 2022 10:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239958AbiEJKmQ (ORCPT ); Tue, 10 May 2022 06:42:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239830AbiEJKmG (ORCPT ); Tue, 10 May 2022 06:42:06 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95C03267C21 for ; Tue, 10 May 2022 03:38:09 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id s30so29881976ybi.8 for ; Tue, 10 May 2022 03:38:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=18Z/sTz+IhJS4WIQidF8Pkf7x0QFtzeGTd5zgt1XcsI=; b=mce5YmBbmq67J2zhZTHGEv91yobyh5mk7B2CT3fMjjAqcnjQubzRIntpwRppCEnqp+ rmbixFACXH1Fa3+8SQbPTl8SgT/K4WNPHtxz5QmUUgQ0SUdbjb5qhG6im/W3dUulSp/u HJ+wUlbTR0YAU9r1YHMPQhrxD5BLUFa1TOZJo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=18Z/sTz+IhJS4WIQidF8Pkf7x0QFtzeGTd5zgt1XcsI=; b=fRXx4ibbZz/wdgbd7s0I/5c25DDgNTcTKB9OmxrgR7CE4/dGHiY8PqOcaHGiPX2USE BuBiKq3z0S1W+IzWnBiiMmN4V+dj/AmybRdiVhA/I6i/ErbWSvkecgVtfUuH6uhhIWTO atTGikPKLdGnQC6Kcb76JVs7GMw7Ml1WU2zA0EIx7NfDEn+b8LzhVrLE79Q8WPZmqZC2 /duVYf1uqO/B85mBawx9fvYKr/XSRhuf2goicbaWuXjDPW21SpnbQkk3WmnKVeaR5A8s tmxhus4y95Ae8FWjPJ9GHu9jfy6L33JbS2t0onQsa3qUJ5uEcQ7rCNLyG/S6+xOUXLiI Y4dA== X-Gm-Message-State: AOAM532u+mJvJC2o45fy+57op7yRYF12J+I5r88//6FC6x3lD5/EVE4e v6KnJylQW7xb2TzpgodBYrDK9d7/4C4EFhMA8eknRQ== X-Google-Smtp-Source: ABdhPJydfNAKQMhJh5sK/HAXZvb2Kunl4GtH2wnKZ/ZK7z6LCCVG+1efFg9HYbdUR9Jq5koVxnXByhS4ux49LykcTBs= X-Received: by 2002:a05:6902:1501:b0:649:ff91:5409 with SMTP id q1-20020a056902150100b00649ff915409mr17647450ybu.278.1652179088847; Tue, 10 May 2022 03:38:08 -0700 (PDT) MIME-Version: 1.0 References: <20220509044302.27878-1-rex-bc.chen@mediatek.com> <20220509044302.27878-2-rex-bc.chen@mediatek.com> <1c3fd336-1450-9b68-df81-2f01cc2ba32f@linaro.org> In-Reply-To: <1c3fd336-1450-9b68-df81-2f01cc2ba32f@linaro.org> From: Chen-Yu Tsai Date: Tue, 10 May 2022 18:37:57 +0800 Message-ID: Subject: Re: [PATCH v2 1/3] dt-bindings: mediatek: add vdosys1 RDMA definition for mt8195 To: Krzysztof Kozlowski Cc: Rex-BC Chen , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "chunkuang.hu@kernel.org" , "p.zabel@pengutronix.de" , "devicetree@vger.kernel.org" , "airlied@linux.ie" , =?UTF-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Project_Global_Chrome_Upstream_Group , =?UTF-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "linux-mediatek@lists.infradead.org" , "matthias.bgg@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "angelogioacchino.delregno@collabora.com" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 10, 2022 at 6:28 PM Krzysztof Kozlowski wrote: > > On 09/05/2022 10:45, Rex-BC Chen wrote: > >>> + soc { > >>> + #address-cells = <2>; > >>> + #size-cells = <2>; > >>> + > >>> + vdo1_rdma0: mdp-rdma@1c104000 { > >> > >> Generic node name. dma-controller (if it does not conflict with > >> dma-common.yaml schema)? > > > > We don't understand what dma-controller you are referring to? Can you > > help explain more? Thanks! > > Use a generic node name, as Devicetree spec asks: > "The name of a node should be somewhat generic, reflecting the function > of the device and not its precise programming > > model. If appropriate, the name should be one of the following choices:" > > I proposed dma-controller, but feel free to find better generic node name. dma-controller is covered by dma-controller.yaml, which references dma-common.yaml in its entirety, so I don't think that would work. What about "blitter"? I think that is a generic term that is/was commonly used with display hardware and sort of describes the function of the RDMA & WDMA blocks, and if only one side is memory and the other is the display pipeline. Regards ChenYu