From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B62AC47E4B for ; Thu, 15 Jul 2021 05:24:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9E3261360 for ; Thu, 15 Jul 2021 05:24:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239070AbhGOF0w (ORCPT ); Thu, 15 Jul 2021 01:26:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237563AbhGOF0u (ORCPT ); Thu, 15 Jul 2021 01:26:50 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12445C06175F for ; Wed, 14 Jul 2021 22:23:57 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id g8so1855074lfh.8 for ; Wed, 14 Jul 2021 22:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7gHi8C85J19Z/buybEtbR7DxC+/60ag6de4D5gu0A4s=; b=TfwneCGKNPpYSyMgTbwLjXIVq/VuCm7QkyuoeUAOKk34NKwSLSvfuumyE2Tn5vcnhf Tq1R1u4BlNAy4HcyQLVmse3G5iI9aKNHs5YBXdVGpV4jZggqG9W4piFHQgJwvptXZXSM A2bCx760it7lS+DmEQzq5Z1TBJaNGZgDHKdqo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7gHi8C85J19Z/buybEtbR7DxC+/60ag6de4D5gu0A4s=; b=J40WHr46U+aPnzemLrJ4aR4mm2vzesHjUPL+cxsj0Y6l9hSRuCLQZhlUnxGhgMAe47 0jW17Ng+Uiuf+MTw7mDAFjWK7hcR7t4jUh77rgnuFKZ3kLwx1B7ibmtksXCfUtINdHSj NdzM5XJLgjR58XL7tFdr+g6jKWVMvuyzSM6REaucA8OdoNyD2OE9JKwXp3cRF80cNqWx 8fKi0plV9g13VB4xNadJdKBSxi+wmznGOsZ4jXLlGvz7xmiYJKdWqEs6sS9Y1B1dP4j3 G1BAJA4c9Prr2+jLswcz4ODdPNsitegrHpZ4SsmvDNlbY290FFTDJr7d6hdpRdeq28+L iDng== X-Gm-Message-State: AOAM531PF6BiVD/1fQ1DcxcFf3pVwq58ZY9TXokrFnV6LoITFYR7zfbD L89a7w3TFvDY0MhOR8VvO+gfZZ3/Evj8VuU3VulCeQ== X-Google-Smtp-Source: ABdhPJxyzZdXZbHnyDFU0e2E2xXXk9NuHsijUMcorMgs2GSg8C6hPxXb3FRaE5BAUxs943DBYUCs6RGDAffpPPVO4Cc= X-Received: by 2002:ac2:53a3:: with SMTP id j3mr1809482lfh.479.1626326635394; Wed, 14 Jul 2021 22:23:55 -0700 (PDT) MIME-Version: 1.0 References: <1626316157-24935-1-git-send-email-kewei.xu@mediatek.com> <1626316157-24935-4-git-send-email-kewei.xu@mediatek.com> In-Reply-To: <1626316157-24935-4-git-send-email-kewei.xu@mediatek.com> From: Chen-Yu Tsai Date: Thu, 15 Jul 2021 13:23:44 +0800 Message-ID: Subject: Re: [PATCH 3/8] i2c: mediatek: fixing the incorrect register offset To: Kewei Xu Cc: wsa@the-dreams.de, Matthias Brugger , Rob Herring , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, LKML , linux-mediatek@lists.infradead.org, srv_heupstream , leilk.liu@mediatek.com, qii.wang@mediatek.com, qiangming.xia@mediatek.com, ot_daolong.zhu@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Jul 15, 2021 at 10:31 AM Kewei Xu wrote: > > The reason for the modification here is that the previous > offset information is incorrect, OFFSET_DEBUGSTAT = 0xE4 is > the correct value. > > Signed-off-by: Kewei Xu This needs a fixes tag: Fixes: 25708278f810 ("i2c: mediatek: Add i2c support for MediaTek MT8183") Otherwise, Reviewed-by: Chen-Yu Tsai