From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74865ECAAD6 for ; Fri, 26 Aug 2022 04:09:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243977AbiHZEJH (ORCPT ); Fri, 26 Aug 2022 00:09:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237153AbiHZEJE (ORCPT ); Fri, 26 Aug 2022 00:09:04 -0400 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 704B2C6EBC for ; Thu, 25 Aug 2022 21:09:02 -0700 (PDT) Received: by mail-ej1-x632.google.com with SMTP id y3so933963ejc.1 for ; Thu, 25 Aug 2022 21:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=nfavuWqsga9k882E8+MW27Dc7w6nkSmp6dmrzCaSBa8=; b=auaX9NL078V2jQ22g6geanRo4qZgCfxascPAwZLxdTpxPyzPYywc2dou1ZYhcRULDj SPoXe+ojJ8cZ26IfVZM+1e593dZ30nsOzMbK8OQ3BD+4Ii44ZUIxjQxzbARwlnIbYBZ4 eFv5ITB4zd1gSGzc6fvPICF/Xe8xA2tDVwNX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=nfavuWqsga9k882E8+MW27Dc7w6nkSmp6dmrzCaSBa8=; b=bcH25ZS5VObQoiVBErjAAIOIgqKcSK0eCp91Hl+nGUcpulWe5xUwI9pWW+9qkaBTI/ IF568oAoukIErgX98w9QG8TOzimhkIvRqekElQW0Ph1zdtMY/tICSnGBjYGhCMkwdZpl wzOAK3MlgifwBZqJYNCCe0rcJaGlnCeKHVvgOUeIzP/Yw6xGXBBZGXfHoLUVCt2DInW0 czjIwvjikK5tN0PAo36Rc8BF4kWedd1GseIFp1TTaZZiyi7KPQrkjK7Zo0Kre1Cj7Pbg 85LAExWOF3/ODNu1jbFRsQZj98aG55gBEgBdkHEko/5lHtKDe7Yu4BeabDLqv+M9pw9e f4Kw== X-Gm-Message-State: ACgBeo3pg16VOWztMmMo6Ypp7AwyrpeFSqFQezBcYOLjOGqc2XbewLlx 3wUQ0O8E6mY0V4YAdc0HCccaq922dlS9VkBijxPzMQ== X-Google-Smtp-Source: AA6agR4P9lJ2jCOXLxO3fu5pzVr8QQon3biII9pZufVQXE6IfPh3piLXnL5yinNDFW3MHI/dSrraW9UClF4wseNeZfY= X-Received: by 2002:a17:907:60c7:b0:739:52ba:cbd0 with SMTP id hv7-20020a17090760c700b0073952bacbd0mr4329186ejc.152.1661486940981; Thu, 25 Aug 2022 21:09:00 -0700 (PDT) MIME-Version: 1.0 References: <20220720085731.11011-1-irui.wang@mediatek.com> <20220720085731.11011-5-irui.wang@mediatek.com> In-Reply-To: <20220720085731.11011-5-irui.wang@mediatek.com> From: Chen-Yu Tsai Date: Fri, 26 Aug 2022 12:08:49 +0800 Message-ID: Subject: Re: [PATCH v2, 4/6] media: mediatek: vcodec: Remove encoder driver get IRQ resource To: Irui Wang Cc: Hans Verkuil , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , angelogioacchino.delregno@collabora.com, Maoguang Meng , Longfei Wang , Yunfei Dong , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jul 20, 2022 at 4:58 PM Irui Wang wrote: > > The "platform_get_resource(pdev, IORESOURCE_IRQ, 0)" is no longer > used after commit a1a2b7125e107("of/platform: Drop static setup of > IRQ resource from DT core"), so just remove the function in > encoder driver to avoid driver probe failed. > > Signed-off-by: Irui Wang > --- > .../media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c > index ea667b867b56..6d8964fb4fa2 100644 > --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c > +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c > @@ -228,7 +228,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > { > struct mtk_vcodec_dev *dev; > struct video_device *vfd_enc; > - struct resource *res; > phandle rproc_phandle; > enum mtk_vcodec_fw_type fw_type; > int ret; > @@ -272,13 +271,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > goto err_res; > } > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > - if (res == NULL) { > - dev_err(&pdev->dev, "failed to get irq resource"); > - ret = -ENOENT; > - goto err_res; > - } > - > dev->enc_irq = platform_get_irq(pdev, 0); platform_get_irq() returns a negative number on failure. You should check for errors here as the previous check was removed. The description of platform_get_irq() explicitly mentions: Device drivers should check the return value for errors so as to not pass a negative integer value to the request_irq() APIs. Hans has queued up this patch, so maybe you could provide a follow-up patch to fix this? Regards ChenYu > irq_set_status_flags(dev->enc_irq, IRQ_NOAUTOEN); > ret = devm_request_irq(&pdev->dev, dev->enc_irq, > -- > 2.18.0 >