From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69BFDC433EF for ; Tue, 22 Mar 2022 09:17:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232431AbiCVJS2 (ORCPT ); Tue, 22 Mar 2022 05:18:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232406AbiCVJSZ (ORCPT ); Tue, 22 Mar 2022 05:18:25 -0400 Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8687929CA2 for ; Tue, 22 Mar 2022 02:16:55 -0700 (PDT) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-2d07ae0b1c0so183212027b3.2 for ; Tue, 22 Mar 2022 02:16:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qBo572xYxqKTaI7lpxz6okPw5Dq0guno4lBVKRNZQ/A=; b=WWB8emCtss3irAeHLhh34BqngG7N6Em0pESEW5mZSmaLFmMVCjPSTEdYvW0PPGByYQ CWymPaVG1aWq+YgWMqMq92aGTNcile6wp/e1UG5RMywSvkHh/zJoT1q1mQObt6KRR1Um eMCEEeKoqbE9hyhq07qhHR3fabTcqjWmo1Fs4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qBo572xYxqKTaI7lpxz6okPw5Dq0guno4lBVKRNZQ/A=; b=VCjMNWAWLm19AadctJ+/egIrf5/wCjnnncFrh5XfBfwYx/kNGobL9bgd2GlcSx8rvK 23R5VRe6zwki+5I6MlkZLpkRH8mLFhvRXSUoyOj+Qch9qfmBRy/VJIHtIoVFCC1+aTnW aF1lNgcXiX2DDKYMGS2vFch/jlQgXVg9CV28gC88t5yxG76NSUjzYo9kHGiMllPpp1UJ rD76Wjolvq6aFVOTF3WR5rYquYOlsUNF2VHWzxvhnbEY1zsZ0TghHk/llQ0Sduh1RhTN 7rb/AhLBHy5JaVhDH/V9Rf3HOJaM335lRaZWaobt6kWQUEgKNhu1J7q3QYhZafusDOTD 7pxQ== X-Gm-Message-State: AOAM533DUkc3i+PdTjwZED/7MjwXzB5w7D1PrxRKdsQVzvB5RKPeNSlp 7KeSml4uSyoB3o9inFHmaZWsoA0kfgYu5auAUyNEMA== X-Google-Smtp-Source: ABdhPJwNO0vnyYt7H/o8k79ta7Lhum+mKBkTV9F1PVSuv9BvIwWbWZNFxtmU7SgMq6HBTpTHeeV9x4XEq1Tkvib4VC4= X-Received: by 2002:a81:be05:0:b0:2e5:6c26:59fb with SMTP id i5-20020a81be05000000b002e56c2659fbmr28941957ywn.94.1647940614769; Tue, 22 Mar 2022 02:16:54 -0700 (PDT) MIME-Version: 1.0 References: <20220322080213.1487134-1-xji@analogixsemi.com> <20220322085208.GA1487511@anxtwsw-Precision-3640-Tower> In-Reply-To: <20220322085208.GA1487511@anxtwsw-Precision-3640-Tower> From: Chen-Yu Tsai Date: Tue, 22 Mar 2022 17:16:43 +0800 Message-ID: Subject: Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status To: Xin Ji Cc: Hsin-Yi Wang , dri-devel@lists.freedesktop.org, Jonas Karlman , David Airlie , Robert Foss , qwen@analogixsemi.com, Neil Armstrong , linux-kernel@vger.kernel.org, Jernej Skrabec , treapking@chromium.org, pihsun@chromium.org, Laurent Pinchart , Andrzej Hajda , tzungbi@google.com, bliang@analogixsemi.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 22, 2022 at 4:52 PM Xin Ji wrote: > > On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji wrote: > > > > > > As downstream sink was set into standby mode while bridge disabled, > > > this patch used for setting downstream sink into normal status > > > while enable bridge. > > > > > > Signed-off-by: Xin Ji > > > Reviewed-by: Pin-Yen Lin > > > > > > --- > > > V1 -> V2: use dev_dbg replace of dev_info > > > --- > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > index 9a2a19ad4202..dcf3275a00fe 100644 > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > @@ -924,12 +924,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx) > > > { > > > int ret; > > > struct device *dev = &ctx->client->dev; > > > + u8 data; > > > > > > if (!ctx->display_timing_valid) { > > > DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n"); > > > return; > > > } > > > > > > + dev_dbg(dev, "set downstream sink into normal\n"); > > > + /* Downstream sink enter into normal mode */ > > > + data = 1; > > > + ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data); > > > + if (ret < 0) > > > + dev_err(dev, "IO error : set sink into normal mode fail\n"); > > > + > > > > The driver uses DRM_DEV_* for logs. Can we use this? > Hi Hsin-Yi, as comment in drm/drm_print.h: > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* > later. drm_dbg is better than dev_dbg though. With the former, you still get the option to control it with the drm.debug module parameter, unlike the latter which normally gets compiled out. Please use drm_dbg*. ChenYu > Thanks, > Xin > > > > > /* Disable HDCP */ > > > anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f); > > > > > > -- > > > 2.25.1 > > >