From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6F9BC43334 for ; Mon, 25 Jul 2022 09:08:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234533AbiGYJI0 (ORCPT ); Mon, 25 Jul 2022 05:08:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234531AbiGYJIY (ORCPT ); Mon, 25 Jul 2022 05:08:24 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C95D15A21 for ; Mon, 25 Jul 2022 02:08:22 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id c131so18922581ybf.9 for ; Mon, 25 Jul 2022 02:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oSUen1zy2XKJLnLvpszCdjqmfTvZUFc64MJFQlVfVi0=; b=R69nZ9mZ0SdKoqNGRzCSjAak9yI9nBoYofz+j4xzGtlDFdv5pbDtadC57GP+GWd+9P jvhCpenqkQwVB3tTaOYKcydqfj+9lsXbXoAbyBEh70T1CIj21JlmchUawTfSerpP9itW GeoYN8ndVMhL6TBnSNlRrODo44no0yVdPH1l4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oSUen1zy2XKJLnLvpszCdjqmfTvZUFc64MJFQlVfVi0=; b=oRCORMBwa5iwj1zYpjHoJiXdscyVWhfGQ+8Jl4peTASmAtYmDSW9tKiIQxWwQhq7fW RNtZcjZxhILwKDezyBH7+5vmcTWNmPkwlkJmFIuIcNX8K3YHtBFNr9D0uy7i414cH6yc kMVKanI/7dWsti2pSjQEAaU1Hxh5KoxJbZLEpUGjacjLWFlvU+qNz6WfvXy3zRDdBYa8 L3roHMNOiMYE8QNUui9dSKpKbYAyl0QKGXdiWPop2i/dRlP8CJ5UmCLGtlmmkAthcwnD OYbVz+5u5sk88NWZM9q5CA+riy5p08WD0d+jr1ILFLmo2blhLNS1YlQto/m5QZHHGDey EsKA== X-Gm-Message-State: AJIora9v/7DEMnrb8rYS/z4QtX7k0S8WpAGwKHR4yxDAnSxFrNziZtPn IgvTT4L+qGUAAS8jKy2RgrT2bS8eq4UrnCxSu40JbQ== X-Google-Smtp-Source: AGRyM1vV+DR9ya4OmfTlnujVAxn1Io5/3EeD5LRkPcGkkRMbp4gKM1lvDg7+uo4ATywMehanYHIO8iDairtqInRllbM= X-Received: by 2002:a25:6a43:0:b0:66f:d259:7918 with SMTP id f64-20020a256a43000000b0066fd2597918mr8618720ybc.486.1658740101673; Mon, 25 Jul 2022 02:08:21 -0700 (PDT) MIME-Version: 1.0 References: <20220721145017.918102-1-angelogioacchino.delregno@collabora.com> <20220721145017.918102-9-angelogioacchino.delregno@collabora.com> In-Reply-To: <20220721145017.918102-9-angelogioacchino.delregno@collabora.com> From: Chen-Yu Tsai Date: Mon, 25 Jul 2022 17:08:10 +0800 Message-ID: Subject: Re: [PATCH v2 8/8] arm64: dts: mediatek: cherry: Enable MT6315 regulators on SPMI bus To: AngeloGioacchino Del Regno Cc: matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Tinghan Shen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 21, 2022 at 10:54 PM AngeloGioacchino Del Regno wrote: > > All machines in the Cherry platform use MT6315 over SPMI: add the > two instances, providing Vbcpu and Vgpu regulators. > > Signed-off-by: AngeloGioacchino Del Regno Tested-by: Chen-Yu Tsai > --- > .../boot/dts/mediatek/mt8195-cherry.dtsi | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > index 9086a440a995..6219544e9912 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi > @@ -5,6 +5,7 @@ > > #include > #include > +#include > #include "mt8195.dtsi" > #include "mt6359.dtsi" > > @@ -979,6 +980,47 @@ usb_c1: connector@1 { > }; > }; > > +&spmi { > + #address-cells = <2>; > + #size-cells = <0>; > + > + mt6315@6 { > + compatible = "mediatek,mt6315-regulator"; > + reg = <0x6 SPMI_USID>; > + > + regulators { > + mt6315_6_vbuck1: vbuck1 { > + regulator-compatible = "vbuck1"; > + regulator-name = "Vbcpu"; > + regulator-min-microvolt = <300000>; > + regulator-max-microvolt = <1193750>; Tinghan, Could you help confirm these numbers? They must be valid for the big cluster supply, not the PMIC. > + regulator-enable-ramp-delay = <256>; > + regulator-ramp-delay = <6250>; > + regulator-allowed-modes = <0 1 2>; > + regulator-always-on; > + }; > + }; > + }; > + > + mt6315@7 { > + compatible = "mediatek,mt6315-regulator"; > + reg = <0x7 SPMI_USID>; > + > + regulators { > + mt6315_7_vbuck1: vbuck1 { > + regulator-compatible = "vbuck1"; > + regulator-name = "Vgpu"; > + regulator-min-microvolt = <625000>; > + regulator-max-microvolt = <1193750>; Same here for the GPU. Thanks ChenYu > + regulator-enable-ramp-delay = <256>; > + regulator-ramp-delay = <6250>; > + regulator-allowed-modes = <0 1 2>; > + regulator-always-on; > + }; > + }; > + }; > +}; > + > &u3phy0 { > status = "okay"; > }; > -- > 2.35.1 > >