From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B35AC4338F for ; Mon, 23 Aug 2021 12:03:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 811396127B for ; Mon, 23 Aug 2021 12:03:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236915AbhHWMDu (ORCPT ); Mon, 23 Aug 2021 08:03:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236836AbhHWMD3 (ORCPT ); Mon, 23 Aug 2021 08:03:29 -0400 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AC6CC06175F for ; Mon, 23 Aug 2021 05:02:46 -0700 (PDT) Received: by mail-lf1-x12c.google.com with SMTP id u22so37363324lfq.13 for ; Mon, 23 Aug 2021 05:02:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=k1wN6uWWUAEncK245AcEkXi5X3BYGhPR13+cEKc80po=; b=IQhmAOTh076A8tMT6pk5HbQgbaeVpSVv5uJSMAJwH3wR/oCvOzx29eHnE6YNtmNo3D r1dogrV1Dcy5VXqbQGikn8CVjv/9HMI+9sw8jPjJf57RIHJJ7aQZYd/A8Km8wDhreyqB yEAFrozQ76vPYJ7DcZVdYpdIyh9pWQiYWCvpY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k1wN6uWWUAEncK245AcEkXi5X3BYGhPR13+cEKc80po=; b=G+irD5cchakQEDoTT/8FA80fFKf4qiyLkJ5z6ILyR9sIa/Iz4juMBDTOeL9ksaZCnJ IfqUqadgu7mFFF9CQtXR01IWaCiN4HWe8c3AHRdDw9Rz6u36YapFBe9Nh5TipKD+mllp AMRUjU4FShd+88BQn+c1gJ5mGUIK6Y/ink0idvnGHNERwqAlU9OabUs+5lIcIVJAJq+U XLhPGpHlReBsZzRFryrANjenNKke5lPpimeqnaA7jR+UIE5fKEriJwgOFxIr2mnZVkWD ZWT+Prq06eODHLPyvZk1E/yMnk11CoOSJBPYCkWDW/dfiLnJ0gne5fLqSVS4UJHuHHH9 VZQQ== X-Gm-Message-State: AOAM530IyfRLUin7QF/JnjjHji4Fc01IVKOEKeE4fMTZAe6zUS5uIsCH ATPa7u/ig9qRtwfq5chjHGdZNVMdZ8yhoBdkloWYtA== X-Google-Smtp-Source: ABdhPJyH1oi6Z4h+7qyE77UctpAsFaN4P2z2I8M6V2yCSw97FXpzm2rm4h5jNd7jUciTrW6+SfLgUk14QDVhIU48l8g= X-Received: by 2002:ac2:5e8f:: with SMTP id b15mr22598853lfq.656.1629720163409; Mon, 23 Aug 2021 05:02:43 -0700 (PDT) MIME-Version: 1.0 References: <20210820111504.350-1-chun-jie.chen@mediatek.com> <20210820111504.350-15-chun-jie.chen@mediatek.com> In-Reply-To: <20210820111504.350-15-chun-jie.chen@mediatek.com> From: Chen-Yu Tsai Date: Mon, 23 Aug 2021 20:02:32 +0800 Message-ID: Subject: Re: [v2 14/24] clk: mediatek: Add MT8195 mfgcfg clock support To: Chun-Jie Chen Cc: Matthias Brugger , Stephen Boyd , Nicolas Boichat , Rob Herring , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , LKML , "moderated list:ARM/Mediatek SoC support" , linux-clk@vger.kernel.org, Devicetree List , srv_heupstream , Project_Global_Chrome_Upstream_Group Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 20, 2021 at 7:26 PM Chun-Jie Chen wrote: > > Add MT8195 mfg clock controller which provides clock gate > control for Main Frame Graphic. I think it would be easier to understand if it just said GPU instead. Or it could write: ... for Main Frame Graphic, aka integrated GPU. Try to use more generic terms. The idea is for people with at least some basic knowledge to be able to understand. > Signed-off-by: Chun-Jie Chen > --- > drivers/clk/mediatek/Makefile | 2 +- > drivers/clk/mediatek/clk-mt8195-mfg.c | 47 +++++++++++++++++++++++++++ > 2 files changed, 48 insertions(+), 1 deletion(-) > create mode 100644 drivers/clk/mediatek/clk-mt8195-mfg.c > > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > index 84d315a6b3e4..042db433245a 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -81,6 +81,6 @@ obj-$(CONFIG_COMMON_CLK_MT8192_SCP_ADSP) += clk-mt8192-scp_adsp.o > obj-$(CONFIG_COMMON_CLK_MT8192_VDECSYS) += clk-mt8192-vdec.o > obj-$(CONFIG_COMMON_CLK_MT8192_VENCSYS) += clk-mt8192-venc.o > obj-$(CONFIG_COMMON_CLK_MT8195) += clk-mt8195-apmixedsys.o clk-mt8195-topckgen.o clk-mt8195-peri_ao.o clk-mt8195-infra_ao.o clk-mt8195-cam.o \ > - clk-mt8195-ccu.o clk-mt8195-img.o clk-mt8195-ipe.o > + clk-mt8195-ccu.o clk-mt8195-img.o clk-mt8195-ipe.o clk-mt8195-mfg.o Wrap line, please. Regards ChenYu > obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o > obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o > diff --git a/drivers/clk/mediatek/clk-mt8195-mfg.c b/drivers/clk/mediatek/clk-mt8195-mfg.c > new file mode 100644 > index 000000000000..0a81fe1fe50e > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8195-mfg.c > @@ -0,0 +1,47 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +// > +// Copyright (c) 2021 MediaTek Inc. > +// Author: Chun-Jie Chen > + > +#include "clk-gate.h" > +#include "clk-mtk.h" > + > +#include > +#include > +#include > + > +static const struct mtk_gate_regs mfg_cg_regs = { > + .set_ofs = 0x4, > + .clr_ofs = 0x8, > + .sta_ofs = 0x0, > +}; > + > +#define GATE_MFG(_id, _name, _parent, _shift) \ > + GATE_MTK(_id, _name, _parent, &mfg_cg_regs, _shift, &mtk_clk_gate_ops_setclr) > + > +static const struct mtk_gate mfg_clks[] = { > + GATE_MFG(CLK_MFG_BG3D, "mfg_bg3d", "top_mfg_core_tmp", 0), > +}; > + > +static const struct mtk_clk_desc mfg_desc = { > + .clks = mfg_clks, > + .num_clks = ARRAY_SIZE(mfg_clks), > +}; > + > +static const struct of_device_id of_match_clk_mt8195_mfg[] = { > + { > + .compatible = "mediatek,mt8195-mfgcfg", > + .data = &mfg_desc, > + }, { > + /* sentinel */ > + } > +}; > + > +static struct platform_driver clk_mt8195_mfg_drv = { > + .probe = mtk_clk_simple_probe, > + .driver = { > + .name = "clk-mt8195-mfg", > + .of_match_table = of_match_clk_mt8195_mfg, > + }, > +}; > +builtin_platform_driver(clk_mt8195_mfg_drv); > -- > 2.18.0 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek