From: Chen-Yu Tsai <wenst@chromium.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: airlied@gmail.com, daniel@ffwll.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com,
alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com,
robh@kernel.org, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 06/10] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186
Date: Thu, 23 Feb 2023 10:43:50 +0800 [thread overview]
Message-ID: <CAGXv+5H3XMF7ov_WfNFA=HC0frD003MRdVuBOFiBvu8zxE_rwg@mail.gmail.com> (raw)
In-Reply-To: <88a3fa09-60cb-bb3c-c392-286efd983627@collabora.com>
On Wed, Feb 22, 2023 at 5:13 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 22/02/23 09:37, Chen-Yu Tsai ha scritto:
> > On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno
> > <angelogioacchino.delregno@collabora.com> wrote:
> >>
> >> Get GPU support on MT8186 by adding its compatible.
> >>
> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> >> ---
> >> Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> >> index be18b161959b..43a841d4e94d 100644
> >> --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> >> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml
> >> @@ -15,6 +15,11 @@ properties:
> >>
> >> compatible:
> >> oneOf:
> >> + - items:
> >> + - enum:
> >> + - mediatek,mt8186-mali
> >> + - const: mediatek,mt8183b-mali
> >> + - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable
> >
> > The MT8186 has Mali-G52 MC2 2EE, while the MT8183 has Mali-G72 MP3.
>
> Keeping in mind the obvious - which is that G52 and G72 are both Bifrost....
>
> > So we actually need a new entry with two power domains.
> >
>
> ...This is my node for MT8186:
>
> gpu: gpu@13040000 {
> compatible = "mediatek,mt8186-mali",
> "mediatek,mt8183b-mali",
> "arm,mali-bifrost";
> reg = <0 0x13040000 0 0x4000>;
>
> clocks = <&mfgsys CLK_MFG_BG3D>;
> interrupts = <GIC_SPI 276 IRQ_TYPE_LEVEL_HIGH 0>,
> <GIC_SPI 275 IRQ_TYPE_LEVEL_HIGH 0>,
> <GIC_SPI 274 IRQ_TYPE_LEVEL_HIGH 0>;
> interrupt-names = "job", "mmu", "gpu";
> power-domains = <&spm MT8186_POWER_DOMAIN_MFG1>,
> <&spm MT8186_POWER_DOMAIN_MFG2>,
> <&spm MT8186_POWER_DOMAIN_MFG3>;
> power-domain-names = "core0", "core1", "core2";
>
> /* Please ignore speedbin, that's for another time :-) */
> nvmem-cells = <&gpu_volt_bin>;
> nvmem-cell-names = "speed-bin";
> #cooling-cells = <2>;
> };
>
> There are three MFG power domains... MFG2 and MFG3 are parents of MFG1, on that
> I agree, but we can avoid adding a new entry just for MT8186 and use the MT8183-b
> one while still being technically correct.
>
> Besides, Mali G52 and Mali G72 are both Bifrost... so I don't think that this
> commit is incorrect. For the sake of simplicity, I would push on getting this
> one picked.
I'm aware. In case it wasn't obvious, Mali-G52 MC2 2EE has 2 cores, while
Mali-G72 MP3 has 3 cores. I think that is reason enough to do a new entry.
Otherwise you are describing power domains for 3 cores for a GPU that only
has two.
> Unless there are any real-strong opinions against...
Yes.
ChenYu
next prev parent reply other threads:[~2023-02-23 2:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 15:37 [PATCH v2 00/10] Panfrost: Improve and add MediaTek SoCs support AngeloGioacchino Del Regno
2023-02-21 15:37 ` [PATCH v2 01/10] dt-bindings: gpu: mali-bifrost: Add power-domain-names to base schema AngeloGioacchino Del Regno
2023-02-21 15:37 ` [PATCH v2 02/10] dt-bindings: gpu: mali-bifrost: Split out MediaTek power-domains variation AngeloGioacchino Del Regno
2023-02-22 7:58 ` Chen-Yu Tsai
2023-02-21 15:37 ` [PATCH v2 03/10] dt-bindings: gpu: mali-bifrost: Allow up to 5 power domains for MT8192 AngeloGioacchino Del Regno
2023-02-22 8:00 ` Chen-Yu Tsai
2023-02-21 15:37 ` [PATCH v2 04/10] dt-bindings: gpu: mali-bifrost: Add compatible for MT8195 SoC AngeloGioacchino Del Regno
2023-02-22 8:01 ` Chen-Yu Tsai
2023-02-21 15:37 ` [PATCH v2 05/10] dt-bindings: gpu: mali-bifrost: Add new MT8183 compatible AngeloGioacchino Del Regno
2023-02-22 8:01 ` Chen-Yu Tsai
2023-02-21 15:37 ` [PATCH v2 06/10] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186 AngeloGioacchino Del Regno
2023-02-22 8:37 ` Chen-Yu Tsai
2023-02-22 9:13 ` AngeloGioacchino Del Regno
2023-02-23 2:43 ` Chen-Yu Tsai [this message]
2023-02-23 13:15 ` AngeloGioacchino Del Regno
2023-02-21 15:37 ` [PATCH v2 07/10] drm/panfrost: Increase MAX_PM_DOMAINS to 5 AngeloGioacchino Del Regno
2023-02-22 4:38 ` Chen-Yu Tsai
2023-02-21 15:37 ` [PATCH v2 08/10] drm/panfrost: Add the MT8192 GPU ID AngeloGioacchino Del Regno
2023-02-22 4:11 ` Chen-Yu Tsai
2023-02-21 15:37 ` [PATCH v2 09/10] drm/panfrost: Add mediatek,mt8192-mali compatible AngeloGioacchino Del Regno
2023-02-22 4:39 ` Chen-Yu Tsai
2023-02-21 15:37 ` [PATCH v2 10/10] drm/panfrost: Add new compatible for Mali on the MT8183 SoC AngeloGioacchino Del Regno
2023-02-22 7:06 ` Chen-Yu Tsai
2023-02-22 7:55 ` [PATCH v2 00/10] Panfrost: Improve and add MediaTek SoCs support Chen-Yu Tsai
2023-02-22 8:39 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXv+5H3XMF7ov_WfNFA=HC0frD003MRdVuBOFiBvu8zxE_rwg@mail.gmail.com' \
--to=wenst@chromium.org \
--cc=airlied@gmail.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).