From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C88A3C433F5 for ; Fri, 7 Oct 2022 04:02:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbiJGECU (ORCPT ); Fri, 7 Oct 2022 00:02:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbiJGECR (ORCPT ); Fri, 7 Oct 2022 00:02:17 -0400 Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C147FC459D for ; Thu, 6 Oct 2022 21:02:15 -0700 (PDT) Received: by mail-ua1-x92a.google.com with SMTP id f4so1306429uav.3 for ; Thu, 06 Oct 2022 21:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ONW7pwCwlyGXd37ijro89iqfnw+jYXGvO6QktN1KnzE=; b=R0eQUb2ifkNhm9A7a9ekJr6xeRJsCe9k4FPFdSRJvuvSCC3kvYNPM0A7FvfZd+1jkT /K9TmzB2R0/GUXenPY0dId6zMfRXw884b3zoxVzFQXvNdYTo8U0nVaji2AJGmRBJ2/2n vJDnRKk4bBtC0iMqBcSUiHdD92g7OYBuXu5R8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ONW7pwCwlyGXd37ijro89iqfnw+jYXGvO6QktN1KnzE=; b=iJt3o9LCUWQopDw2DsJmeA8HjSZ66qwcHXi/5lhp1zbQhlDTVYJPqHH6gfMEeyr0BH 5f0X6xxIFoCVDQAI4wJ3tMhPNqo2hgrut1GuVbpi7KAeC0eTu+mVp+OF9r6sxmhXMqV7 dw0rYCmSLdBCLQiGcstGgApS0HpquQJzMJqg4Gx8s8auSusy50jNynIi3KUwf55kUF95 I0c4xSoVVWEyguix2E32RLAvvDCY727/hwAdl5bfUXmqiUzYaDTum8JF9YdC3hlFPUue WTK0Qti4qacraggDYOivLa0Z+cqKjpsWSla0trjqZBH8zzBaz9di/3hBGikltSCuxqf/ nomQ== X-Gm-Message-State: ACrzQf34dEJVfRwSFhGl/sUiUQ95Y9bvlylm3l4VYjLCpDv96n1/zU5U illK1UFotoxiiprUIUpNXzA6HOVUVGnXLyHLp0mrfA== X-Google-Smtp-Source: AMsMyM4l1ulp/7lmSsZbh8zin/EMci1G3NMqRlBHpokLnB623aj1PQZYjLxHUSfOPtH8F6WLdv5y+ZxfqbbrdM67/lA= X-Received: by 2002:ab0:38c5:0:b0:383:eed8:dd45 with SMTP id l5-20020ab038c5000000b00383eed8dd45mr2157129uaw.11.1665115334922; Thu, 06 Oct 2022 21:02:14 -0700 (PDT) MIME-Version: 1.0 References: <20221006212528.103790-1-nfraprado@collabora.com> <20221006212528.103790-6-nfraprado@collabora.com> In-Reply-To: From: Chen-Yu Tsai Date: Fri, 7 Oct 2022 12:02:03 +0800 Message-ID: Subject: Re: [PATCH v2 5/5] arm64: dts: mediatek: asurada: Add aliases for i2c and mmc To: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Cc: Matthias Brugger , kernel@collabora.com, AngeloGioacchino Del Regno , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 7, 2022 at 11:51 AM Chen-Yu Tsai wrote: > > On Fri, Oct 7, 2022 at 5:25 AM N=C3=ADcolas F. R. A. Prado > wrote: > > > > Add aliases for the i2c and mmc nodes on the Asurada platform DT to > > ensure that we get stable ids for those devices on userspace. > > > > Signed-off-by: N=C3=ADcolas F. R. A. Prado > > > > --- > > > > Changes in v2: > > - Added this commit > > > > arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/ar= m64/boot/dts/mediatek/mt8192-asurada.dtsi > > index dac2d4f5e670..758ca42a6156 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > @@ -11,6 +11,18 @@ > > > > / { > > aliases { > > + i2c0 =3D &i2c0; > > + i2c1 =3D &i2c1; > > + i2c2 =3D &i2c2; > > + i2c3 =3D &i2c3; > > + i2c4 =3D &i2c4; > > + i2c5 =3D &i2c5; > > + i2c6 =3D &i2c6; > > + i2c7 =3D &i2c7; > > + i2c8 =3D &i2c8; > > + i2c9 =3D &i2c9; > > You should only add aliases for interfaces that are actually enabled. > > Also, I think we can disable i2c6. None of the current products use it. > > ChenYu > > > + mmc0 =3D &mmc0; > > + mmc1 =3D &mmc1; Also, Spherion does not have an SD card slot. It might be better to move the mmc aliases to the end .dts files. ChenYu