* [PATCH v3 1/2] arm64: dts: mt8183: kukui: Use aliases to mmc nodes
@ 2021-07-27 11:22 Hsin-Yi Wang
2021-07-27 11:22 ` [PATCH 2/2] arm64: dts: mt8173: elm: " Hsin-Yi Wang
0 siblings, 1 reply; 3+ messages in thread
From: Hsin-Yi Wang @ 2021-07-27 11:22 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Enric Balletbo Serra, eizan, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
fa2d0aa96941 ("mmc: core: Allow setting slot index via device tree alias")
allows the use of aliases to number SD/MMC slots. This patch use aliases
to mmc nodes so the partition name for eMMC and SD card will be consistent
across boots.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
v2->v3: fix indentation error and add more commit message.
---
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index ae549d55a94fc..8e9cf36a9a41a 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -13,6 +13,8 @@
/ {
aliases {
serial0 = &uart0;
+ mmc0 = &mmc0;
+ mmc1 = &mmc1;
};
chosen {
--
2.32.0.432.gabb21c7263-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] arm64: dts: mt8173: elm: Use aliases to mmc nodes
2021-07-27 11:22 [PATCH v3 1/2] arm64: dts: mt8183: kukui: Use aliases to mmc nodes Hsin-Yi Wang
@ 2021-07-27 11:22 ` Hsin-Yi Wang
2021-07-28 3:51 ` Chen-Yu Tsai
0 siblings, 1 reply; 3+ messages in thread
From: Hsin-Yi Wang @ 2021-07-27 11:22 UTC (permalink / raw)
To: Matthias Brugger
Cc: Rob Herring, Enric Balletbo Serra, eizan, devicetree,
linux-arm-kernel, linux-mediatek, linux-kernel
fa2d0aa96941 ("mmc: core: Allow setting slot index via device tree alias")
allows the use of aliases to number SD/MMC slots. This patch use aliases
to mmc nodes so the partition name for eMMC and SD card will be consistent
across boots.
Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
---
v2->v3: add more commit message.
---
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index 21452c51a20a8..d5a2cad39c9c7 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -10,6 +10,12 @@
#include "mt8173.dtsi"
/ {
+ aliases {
+ mmc0 = &mmc0;
+ mmc1 = &mmc1;
+ mmc2 = &mmc3;
+ };
+
memory@40000000 {
device_type = "memory";
reg = <0 0x40000000 0 0x80000000>;
--
2.32.0.432.gabb21c7263-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] arm64: dts: mt8173: elm: Use aliases to mmc nodes
2021-07-27 11:22 ` [PATCH 2/2] arm64: dts: mt8173: elm: " Hsin-Yi Wang
@ 2021-07-28 3:51 ` Chen-Yu Tsai
0 siblings, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2021-07-28 3:51 UTC (permalink / raw)
To: Hsin-Yi Wang
Cc: Matthias Brugger, Rob Herring, Enric Balletbo Serra,
Eizan Miyamoto, Devicetree List,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
moderated list:ARM/Mediatek SoC support, LKML
Hi,
The subject for this patch wasn't tagged with v3. This might cause some
issues with scripted tooling.
On Tue, Jul 27, 2021 at 7:22 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
>
> fa2d0aa96941 ("mmc: core: Allow setting slot index via device tree alias")
> allows the use of aliases to number SD/MMC slots. This patch use aliases
> to mmc nodes so the partition name for eMMC and SD card will be consistent
> across boots.
Device trees are supposed to be a description of the hardware and
therefore should be implementation agnostic. The commit logs should be
the same, unless the implementation details influenced the changes made.
The MMC binding change already specified that aliases provide a way to
assign fixed mmcN indices, so the log should reference the binding
change commit instead.
ChenYu
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> v2->v3: add more commit message.
> ---
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 21452c51a20a8..d5a2cad39c9c7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -10,6 +10,12 @@
> #include "mt8173.dtsi"
>
> / {
> + aliases {
> + mmc0 = &mmc0;
> + mmc1 = &mmc1;
> + mmc2 = &mmc3;
> + };
> +
> memory@40000000 {
> device_type = "memory";
> reg = <0 0x40000000 0 0x80000000>;
> --
> 2.32.0.432.gabb21c7263-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-28 3:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-27 11:22 [PATCH v3 1/2] arm64: dts: mt8183: kukui: Use aliases to mmc nodes Hsin-Yi Wang
2021-07-27 11:22 ` [PATCH 2/2] arm64: dts: mt8173: elm: " Hsin-Yi Wang
2021-07-28 3:51 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).