linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kyle Tso <kyletso@google.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Greg KH <gregkh@linuxfoundation.org>,
	Badhri Jagan Sridharan <badhri@google.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tcpm: collision avoidance
Date: Fri, 22 Mar 2019 19:54:06 +0800	[thread overview]
Message-ID: <CAGZ6i=1ZyftH6CcMvpeWz9tLwJxusaOyz5BOaSS3YP2mijSQCw@mail.gmail.com> (raw)
In-Reply-To: <CAGZ6i=0qeF1YU9N3pnKjejsKY76bY_sfqbwN83LWMRMr82k=nA@mail.gmail.com>

On Fri, Mar 22, 2019 at 12:51 AM Kyle Tso <kyletso@google.com> wrote:
>
> On Wed, Mar 20, 2019 at 1:38 AM Guenter Roeck <linux@roeck-us.net> wrote:
> >

> > >  static enum tcpm_state tcpm_default_state(struct tcpm_port *port)
> > >  {
> > >       if (port->port_type == TYPEC_PORT_DRP) {
> > > @@ -600,6 +664,9 @@ static void tcpm_debugfs_exit(const struct tcpm_port *port) { }
> > >
> > >  #endif
> > >
> > > +static int tcpm_ams_start(struct tcpm_port *port, enum tcpm_ams ams,
> > > +                       bool start);
> > > +
> >
> > Does this have to be a forward declaration ?
> >
> tcpm_pd_transmit() calls tcpm_ams_start() and tcpm_ams_start() calls
> tcpm_pd_transmit()
>
Since tcpm_ams_start will be divided into two parts, tcpm_pd_transmit no
longer needs to call tcpm_ams_start.

I will remove the forward declaration in the next version.

thanks,
Kyle

      reply	other threads:[~2019-03-22 11:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19  6:40 [PATCH] usb: typec: tcpm: collision avoidance Kyle Tso
2019-03-19 17:38 ` Guenter Roeck
2019-03-21 16:51   ` Kyle Tso
2019-03-22 11:54     ` Kyle Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGZ6i=1ZyftH6CcMvpeWz9tLwJxusaOyz5BOaSS3YP2mijSQCw@mail.gmail.com' \
    --to=kyletso@google.com \
    --cc=badhri@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).